Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #42043) test: use pcapgo package outside packetbeat to avoid cgo dependency #42070

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[8.x](backport #42043) test: use pcapgo package outside packetbeat to avoid cgo dependency #42070

merged 1 commit into from
Dec 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 16, 2024

Proposed commit message

pcap requires cgo so switch to pcapgo outside packetbeat to avoid depending on cgo

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #42043 done by [Mergify](https://mergify.com).

@kruskall @mergify
test: use pcapgo package outside packetbeat to avoid cgo dependency (#…
ee7d871 
…42043)

* test: use pcapgo package outside packetbeat to avoid cgo dependency

pcap requires cgo so switch to pcapgo outside packetbeat to
avoid depending on cgo

* Update integration_test.go

* Update netflow_test.go

* lint: fix linter issues

* lint: missed one pcap use

(cherry picked from commit 6228c7e)
@mergify mergify bot added the backport label Dec 16, 2024
@mergify mergify bot requested review from a team as code owners December 16, 2024 22:06
@mergify mergify bot requested review from leehinman and khushijain21 and removed request for a team December 16, 2024 22:06
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 16, 2024
@botelastic
Copy link

botelastic bot commented Dec 16, 2024

This pull request doesn't have a Team:<team> label.

@kruskall kruskall enabled auto-merge (squash) December 16, 2024 22:25
@kruskall kruskall merged commit 95a6a45 into 8.x Dec 16, 2024
141 checks passed
@kruskall kruskall deleted the mergify/bp/8.x/pr-42043 branch December 16, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruskall kruskall kruskall approved these changes

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@kruskall kruskall

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kruskall