Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15](backport #40075) [filebeat][log] Enable status reporter for log input #40302

Merged
merged 3 commits into from
Aug 12, 2024
Merged

[8.15](backport #40075) [filebeat][log] Enable status reporter for log input #40302

merged 3 commits into from
Aug 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 19, 2024 •
edited by zube bot
Loading

Proposed commit message

Enable StatusReporter for log input which was introduced in #39209

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Use cases

This PR allows the log input to report its status to elastic-agent. This would keep the status of the unit up-to-date and would help with diagnostics.

Screenshots

Logs

This is an automatic backport of pull request #40075 done by [Mergify](https://mergify.com).

@VihasMakwana @mergify
[filebeat][log] Enable status reporter for log input (#40075)
5027c06 
* chore: initial commit, without tests

* chore: tests

* chore: add test cases

* fix: add null check

* fix: remove println

* fix: lint

* goimports

* remove println

* fix: changelog

* update test for windows

* fix: fix some comments

* chore: add starting state in NewInput

* fix: add sample output to verify the status

* fix: remove println

* fix: add integration tag

* Update CHANGELOG.next.asciidoc

Co-authored-by: Denis <denis@rdner.de>

* fix: remove redundant bool

* fix: add degraded

---------

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
Co-authored-by: Denis <denis@rdner.de>
(cherry picked from commit f3f772f)
@mergify mergify bot requested a review from a team as a code owner July 19, 2024 12:23
@mergify mergify bot added the backport label Jul 19, 2024
@mergify mergify bot requested review from AndersonQ and belimawr and removed request for a team July 19, 2024 12:23
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2024
@pierrehilbert pierrehilbert requested review from VihasMakwana and removed request for AndersonQ and belimawr July 19, 2024 14:47
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 19, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2024
@pierrehilbert
Copy link
Collaborator

Shouldn't be merged before 8.15.1

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jul 22, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

1 similar comment
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jul 29, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 5, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 8, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.15/pr-40075 upstream/mergify/bp/8.15/pr-40075
git merge upstream/8.15
git push upstream mergify/bp/8.15/pr-40075

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 12, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

@pierrehilbert pierrehilbert merged commit 9a6b801 into 8.15 Aug 12, 2024
27 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.15/pr-40075 branch August 12, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@rdner rdner rdner approved these changes

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana

Assignees

@VihasMakwana VihasMakwana

Labels
backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elasticmachine @pierrehilbert @rdner @VihasMakwana