Fix spelling mistakes #3434
Fix spelling mistakes #3434
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
| @@ -13,7 +13,7 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| // A PackageFile is an RPM package definition loaded directly from the pacakge | |||
| // A PackageFile is an RPM package definition loaded directly from the package | |||
There was a problem hiding this comment.
Can you remove this one please? It's in a dependency so it doesn't help to much to fix the typo in our vendored copy.
| @@ -167,7 +167,7 @@ func (c *PackageFile) FileSize() uint64 { | |||
| return c.fileSize | |||
| } | |||
|
|
|||
| // Checksum computes and returns the SHA256 checksum (encoded in hexidecimal) of | |||
| // Checksum computes and returns the SHA256 checksum (encoded in hexadecimal) of | |||
| @@ -66,7 +66,7 @@ func (w *worker) tick(t *time.Ticker) bool { | |||
| } | |||
| } | |||
|
|
|||
| func (w *worker) periodicaly(tick time.Duration, fn func() error) { | |||
| func (w *worker) periodically(tick time.Duration, fn func() error) { | |||
There was a problem hiding this comment.
There's some unit test failures which I suspect are caused by this change.
There was a problem hiding this comment.
Should be fixed now
|
Thanks for the fixes, I left some comments. Out of curiosity, did you use a tool for this? Perhaps we can integrate it in our processes. |
|
I ran Gometalinter which includes a number of opinionated suggestions, but the specific linter that caught these was misspell. This is how I added it to Caddy's build. I've personally not had false positives, but might not want to make that a build passing requirement if you choose to adopt it. |
|
jenkins, test it |
|
Thanks @bengadbois! |
No description provided.