Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up changes in documentation after #28927 #29501

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Dec 17, 2021

What does this PR do?

This PR adds the missing documentation changes after the removal of suffix option from logging.

Why is it important?

To let users know what's what. :D

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 17, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2021

This pull request does not have a backport label. Could you fix it @kvch? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 17, 2021
@kvch kvch requested review from a team as code owners December 17, 2021 15:42
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 17, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-17T15:42:45.867+0000

  • Duration: 133 min 36 sec

  • Commit: 7e31862

Test stats 🧪

Test Results
Failed 0
Passed 48649
Skipped 4277
Total 52926

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kvch kvch added backport-v8.0.0 Automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Dec 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 17, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Dec 17, 2021
@belimawr belimawr self-requested a review December 17, 2021 15:52
@belimawr belimawr merged commit 391a948 into elastic:master Dec 22, 2021
mergify bot pushed a commit that referenced this pull request Dec 22, 2021
* Follow up changes in the docs for logging
* add reference configuration

(cherry picked from commit 391a948)
belimawr pushed a commit that referenced this pull request Dec 23, 2021
* Follow up changes in the docs for logging
* add reference configuration

(cherry picked from commit 391a948)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.0.0 Automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants