-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filebeat sophos/utm: Support logs containing hostname in syslog header #28638
Merged
adriansr
merged 2 commits into
elastic:master
from
adriansr:fix_sophos_utm_header_order
Oct 29, 2021
Merged
Filebeat sophos/utm: Support logs containing hostname in syslog header #28638
adriansr
merged 2 commits into
elastic:master
from
adriansr:fix_sophos_utm_header_order
Oct 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
added
Team:Security-External Integrations
backport-v7.16.0
Automated backport with mergify
labels
Oct 26, 2021
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 26, 2021
This pull request is now in conflicts. Could you fix it? 🙏
|
andrewkroh
approved these changes
Oct 28, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2021
) Updates the sophos/utm datastream to support logs that include a hostname in their syslog header. (cherry picked from commit 71204c2)
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…stic#28638) Updates the sophos/utm datastream to support logs that include a hostname in their syslog header.
@Mergifyio refresh |
✅ Pull request refreshed |
adriansr
added a commit
that referenced
this pull request
Nov 11, 2021
) Updates the sophos/utm datastream to support logs that include a hostname in their syslog header. (cherry picked from commit 71204c2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v7.16.0
Automated backport with mergify
backport-v8.0.0
Automated backport with mergify
enhancement
review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the sophos/utm fileset (rsa2elk) so that it prioritizes logs that contain a hostname in their syslog header.
Why is it important?
Without this change, logs with a hostname are not correctly parsed.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Known issues
Note that this change in turn can cause problems with syslog headers that don't contain a hostname. Due to the way the logs are structured, it's not possible to reliably support both scenarios at the same time.
This prioritizes logs with a hostname, hoping that they are more common.
As an example, given the following log (without a hostname):
The current parser will take
smtpd[905]
as hostname,MASTER
as the message ID andNNN
as the process ID.Because of this, is recommended that all logs include a hostname.
Related issues