Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auditbeat] Field cleanup for 8.0 #28378

Merged
merged 4 commits into from
Oct 15, 2021
Merged

[Auditbeat] Field cleanup for 8.0 #28378

merged 4 commits into from
Oct 15, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Oct 13, 2021 •
edited
Loading

What does this PR do?

  • Remove hash.* from Auditbeat file_integrity for 8.0.
  • Remove non-ECS event.type from Auditbeat auditd module.

Relates #19039

Why is it important?

Removes duplicate data from events and better aligns data to ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewkroh
Remove hash.* from Auditbeat file_integrity for 8.0
11dfcd3 
Relates elastic#19039
@andrewkroh
Remove non-ECS event.type from Auditbeat auditd module
c0eb122 
Removes the authentication_success and authentication_failure event.type values for user logins.

Relates elastic#19039
@andrewkroh andrewkroh added Auditbeat breaking change Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify labels Oct 13, 2021
@andrewkroh andrewkroh requested a review from a team as a code owner October 13, 2021 00:39
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 13, 2021
@andrewkroh andrewkroh force-pushed the bugfix/ab/8-0-cleanup branch from 9a6ec13 to eed19d6 Compare October 13, 2021 00:39
@andrewkroh andrewkroh mentioned this pull request Oct 13, 2021
Closed
8 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 13, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-13T17:03:23.979+0000

  • Duration: 51 min 20 sec

  • Commit: 3b337fa

Test stats 🧪

Test Results
Failed 0
Passed 796
Skipped 183
Total 979

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@andrewkroh andrewkroh marked this pull request as draft October 13, 2021 01:22
@andrewkroh
Copy link
Member Author

/test

@andrewkroh andrewkroh marked this pull request as ready for review October 13, 2021 20:32
@andrewkroh andrewkroh merged commit cc7239a into elastic:master Oct 15, 2021
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@andrewkroh
[Auditbeat] Field cleanup for 8.0 (elastic#28378)
eb5f27d 
* Remove `hash.*` from Auditbeat file_integrity for 8.0

Relates elastic#19039

* Remove non-ECS event.type from Auditbeat auditd module

Removes the authentication_success and authentication_failure event.type values for user logins.

Relates elastic#19039
@andrewkroh andrewkroh mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
Auditbeat backport-skip Skip notification from the automated backport with mergify breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkroh @elasticmachine @efd6