auditbeat/module/file_integrity: clean paths obtained from fsnotify before sending #28354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
4bc1d67 to
a3c7ed9
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewkroh
approved these changes
Oct 13, 2021
…nd fsevents before sending Document that while users should configure with an absolute path, the module will attempt to resolve paths to their absolute equivalent.
a3c7ed9 to
7e594c5
Compare
|
@efd6 changelog entries should go to the |
andresrc
added a commit
to andresrc/beats
that referenced
this pull request
Oct 30, 2021
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…nd fsevents before sending (elastic#28354) Document that while users should configure with an absolute path, the module will attempt to resolve paths to their absolute equivalent.
|
@andresrc Thanks. I knew this but fumbled. Sorry. |
andresrc
added a commit
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This cleans incorrectly constructed, but valid, paths obtained from fsnotify and makes relative paths useful.
Note that the code is duplicated across the fsnotify and fsevent functions due to separation by build tags and differences in the types that are being handled. They could be factored into a single
func absolutePathFor(path string, logger *logp.Logger) string, but there was no obvious place to put that.Why is it important?
Currently paths of files identified in root by the file integrity module have path with either a
//prefix or with a./if a relative or empty path configuration is provided. This change resolves relative paths to absolute event paths and cleans paths with extraneous path separators and dots.Testing the root path behaviour in automated testing does not seem feasible.
Checklist
- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
N/A
How to test this PR locally
Run auditbeat with the following configuration
or
and then create a file in
/or in the current working directory for auditbeat.Related issues
Use cases
N/A
Screenshots
N/A
Logs
N/A