-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Update ES ingest pipeline refs #28239
[DOCS] Update ES ingest pipeline refs #28239
Conversation
Changes several 'ingest node' references in the docs to 'ingest pipelines.' While a node with the `ingest` role is required to use Elasticsearch ingest pipelines, we no longer include 'ingest node' in the feature name. There are no official plans, but the Elasticsearch team has discussed removing the `ingest` role in the future. Relates to elastic/elasticsearch#70253.
Pinging @elastic/obs-docs (Team:Docs) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the terminology cleanup. I like this much better!
@jrodewig OK, so I've added some review comments and also pushed a commit that should fix the build error. I have been having A LOT of trouble getting beats builds to pass lately, though, so fingers crossed. |
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
* [DOCS] Add Beats config example for ingest pipelines The Elasticsearch ingest pipeline docs cover ingest pipelines for Fleet and Elastic Agent. However, the docs don't cover Beats. This adds those docs. Relates to elastic/beats#28239. * Update docs/reference/ingest.asciidoc Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Thanks for the review and suggestions @dedemorton. This is ready for another look at your convenience. |
* [DOCS] Add Beats config example for ingest pipelines The Elasticsearch ingest pipeline docs cover ingest pipelines for Fleet and Elastic Agent. However, the docs don't cover Beats. This adds those docs. Relates to elastic/beats#28239. * Update docs/reference/ingest.asciidoc Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co>
* [DOCS] Add Beats config example for ingest pipelines The Elasticsearch ingest pipeline docs cover ingest pipelines for Fleet and Elastic Agent. However, the docs don't cover Beats. This adds those docs. Relates to elastic/beats#28239. * Update docs/reference/ingest.asciidoc Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! LGTM
Thanks @dedemorton! |
Changes several 'ingest node' references in the docs to 'ingest pipeline.' While a node with the `ingest` role is required to use Elasticsearch ingest pipelines, we no longer include 'ingest node' in the feature name. There are no official plans, but the Elasticsearch team has discussed removing the `ingest` role in the future. - elastic/elasticsearch#70253 - elastic/elasticsearch#78633 Co-authored-by: dedemorton <dede.morton@elastic.co>
## What does this PR do? Changes several 'ingest node' references in the docs to 'ingest pipeline.' ## Why is it important? While a node with the `ingest` role is required to use Elasticsearch ingest pipelines, we no longer include 'ingest node' in the feature name. There are no official plans, but the Elasticsearch team has discussed removing the `ingest` role in the future. ## Related issues - elastic/elasticsearch#70253 - elastic/elasticsearch#78633 Co-authored-by: dedemorton <dede.morton@elastic.co>
What does this PR do?
Changes several 'ingest node' references in the docs to 'ingest pipeline.'
Why is it important?
While a node with the
ingest
role is required to use Elasticsearch ingest pipelines, we no longer include 'ingest node' in the feature name.There are no official plans, but the Elasticsearch team has discussed removing the
ingest
role in the future.Checklist
Related issues