Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update ES ingest pipeline refs #28239

Merged
merged 10 commits into from
Oct 5, 2021
Merged

[DOCS] Update ES ingest pipeline refs #28239

merged 10 commits into from
Oct 5, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Oct 4, 2021

What does this PR do?

Changes several 'ingest node' references in the docs to 'ingest pipeline.'

Why is it important?

While a node with the ingest role is required to use Elasticsearch ingest pipelines, we no longer include 'ingest node' in the feature name.

There are no official plans, but the Elasticsearch team has discussed removing the ingest role in the future.

Checklist

  • My code follows the style guidelines of this project

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 4, 2021
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 4, 2021
@jrodewig jrodewig added the Team:Docs Label for the Observability docs team label Oct 4, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 4, 2021
@jrodewig jrodewig added v7.15.0 v7.16.0 v8.0.0 and removed backport-skip Skip notification from the automated backport with mergify labels Oct 4, 2021
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 4, 2021
@jrodewig jrodewig added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Oct 4, 2021
@elastic elastic deleted a comment from mergify bot Oct 4, 2021
@elastic elastic deleted a comment from mergify bot Oct 4, 2021
@elastic elastic deleted a comment from elasticmachine Oct 4, 2021
@elastic elastic deleted a comment from elasticmachine Oct 4, 2021
@jrodewig jrodewig added backport-skip Skip notification from the automated backport with mergify docs and removed backport-v8.0.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify v8.0.0 v7.15.0 v7.16.0 labels Oct 4, 2021
Changes several 'ingest node' references in the docs to 'ingest pipelines.'

While a node with the `ingest` role is required to use Elasticsearch ingest
pipelines, we no longer include 'ingest node' in the feature name.

There are no official plans, but the Elasticsearch team has discussed removing
the `ingest` role in the future.

Relates to elastic/elasticsearch#70253.
@elastic elastic deleted a comment from elasticmachine Oct 4, 2021
@jrodewig jrodewig marked this pull request as ready for review October 4, 2021 19:02
@jrodewig jrodewig requested a review from a team as a code owner October 4, 2021 19:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-05T12:48:50.523+0000

  • Duration: 152 min 59 sec

  • Commit: 0294b59

Test stats 🧪

Test Results
Failed 0
Passed 54183
Skipped 5346
Total 59529

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the terminology cleanup. I like this much better!

@jrodewig jrodewig requested a review from a team as a code owner October 5, 2021 01:04
@dedemorton
Copy link
Contributor

@jrodewig OK, so I've added some review comments and also pushed a commit that should fix the build error. I have been having A LOT of trouble getting beats builds to pass lately, though, so fingers crossed.

jrodewig and others added 2 commits October 5, 2021 05:42
elasticsearchmachine pushed a commit to elastic/elasticsearch that referenced this pull request Oct 5, 2021
* [DOCS] Add Beats config example for ingest pipelines

The Elasticsearch ingest pipeline docs cover ingest pipelines for Fleet and
Elastic Agent. However, the docs don't cover Beats. This adds those docs.

Relates to elastic/beats#28239.

* Update docs/reference/ingest.asciidoc

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@jrodewig
Copy link
Contributor Author

jrodewig commented Oct 5, 2021

Thanks for the review and suggestions @dedemorton. This is ready for another look at your convenience.

@jrodewig jrodewig requested a review from dedemorton October 5, 2021 09:59
elasticsearchmachine pushed a commit to elastic/elasticsearch that referenced this pull request Oct 5, 2021
* [DOCS] Add Beats config example for ingest pipelines

The Elasticsearch ingest pipeline docs cover ingest pipelines for Fleet and
Elastic Agent. However, the docs don't cover Beats. This adds those docs.

Relates to elastic/beats#28239.

* Update docs/reference/ingest.asciidoc

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
elasticsearchmachine pushed a commit to elastic/elasticsearch that referenced this pull request Oct 5, 2021
* [DOCS] Add Beats config example for ingest pipelines

The Elasticsearch ingest pipeline docs cover ingest pipelines for Fleet and
Elastic Agent. However, the docs don't cover Beats. This adds those docs.

Relates to elastic/beats#28239.

* Update docs/reference/ingest.asciidoc

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! LGTM

@jrodewig
Copy link
Contributor Author

jrodewig commented Oct 5, 2021

Thanks @dedemorton!

@jrodewig jrodewig merged commit c3cb365 into elastic:master Oct 5, 2021
@jrodewig jrodewig deleted the docs__update-beats-pipeline-docs branch October 5, 2021 21:08
jrodewig added a commit that referenced this pull request Oct 6, 2021
Changes several 'ingest node' references in the docs to 'ingest pipeline.'

While a node with the `ingest` role is required to use Elasticsearch ingest pipelines, we no longer include 'ingest node' in the feature name.

There are no official plans, but the Elasticsearch team has discussed removing the `ingest` role in the future.

- elastic/elasticsearch#70253
- elastic/elasticsearch#78633

Co-authored-by: dedemorton <dede.morton@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
## What does this PR do?

Changes several 'ingest node' references in the docs to 'ingest pipeline.'

## Why is it important?

While a node with the `ingest` role is required to use Elasticsearch ingest pipelines, we no longer include 'ingest node' in the feature name.

There are no official plans, but the Elasticsearch team has discussed removing the `ingest` role in the future.

## Related issues

- elastic/elasticsearch#70253
- elastic/elasticsearch#78633

Co-authored-by: dedemorton <dede.morton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify docs Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants