-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
name all k8s workqueue #28085
name all k8s workqueue #28085
Conversation
This pull request does not have a backport label. Could you fix it @newly12? 🙏
NOTE: |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Pinging @elastic/integrations (Team:Integrations) |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left one minor
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot @newly12. Let's wait CI to be green and then we will merge it!
This pull request is now in conflicts. Could you fix it? 🙏
|
@newly12 Can you resolve the conflicts in the CHANGELOG.next.asciidoc ? |
Enhancement
What does this PR do?
name all k8s workqueue accordingly
Why is it important?
we have metricbeat running with autodiscover enabled to collect metrics from all pods in the entire cluster, we noticed that in some large clusters(in our case tens of thousands of pods) autodiscover is "slow", for example a new pod could take very long time or forever for metricbeat to start scrapping, however it can be seen after restarti metricbeat for several minutes. we add done these code changes and then leverage the default metrics instrumentation done by controller runtime and identified that there were many items pending on processing in the "pod" workqueue.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
get insights into beats' k8s workqueue
Screenshots
Logs