Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat] Add write access to 'url.value' from 'request.transforms'. #27937

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[filebeat] Add write access to 'url.value' from 'request.transforms'. #27937

merged 1 commit into from
Sep 16, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 15, 2021

What does this PR do?

Adds write access to url.value from the request.transforms context.

Why is it important?

Some use cases require to set the url for the next request from a previously stored value.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr requested a review from P1llus September 15, 2021 10:09
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 15, 2021
@marc-gr marc-gr force-pushed the httpjson-access-url.value branch from 39486bc to 2782efb Compare September 15, 2021 10:10
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-15T10:10:56.888+0000

  • Duration: 90 min 35 sec

  • Commit: 2782efb

Test stats 🧪

Test Results
Failed 0
Passed 8223
Skipped 1201
Total 9424

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8223
Skipped 1201
Total 9424

@marc-gr marc-gr merged commit 680fb5b into elastic:master Sep 16, 2021
@marc-gr marc-gr deleted the httpjson-access-url.value branch September 16, 2021 07:02
mergify bot pushed a commit that referenced this pull request Sep 16, 2021
@marc-gr
Add write access to 'url.value' from 'request.transforms'. (#27937)
a84932a 
(cherry picked from commit 680fb5b)
@mergify mergify bot mentioned this pull request Sep 16, 2021
Merged
marc-gr added a commit that referenced this pull request Sep 16, 2021
@mergify @marc-gr
Add write access to 'url.value' from 'request.transforms'. (#27937) (#…
7c8c06e 
…27962)

(cherry picked from commit 680fb5b)

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
v1v added a commit to v1v/beats that referenced this pull request Sep 20, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-fleet
10d1617 
* upstream/master: (658 commits)
  Add complete k8s metadata through composable provider (elastic#27691)
  Revert "Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969)" (elastic#27997)
  Remove deprecated kafka fields (elastic#27938)
  [Filebeat] Add Base64 encoded HMAC & UUID template functions to httpjson input (elastic#27873)
  Improve httpjson template function join (elastic#27996)
  Remove kubernetes.container.image alias (elastic#27898)
  [Elastic Agent] Golden files for program tests (elastic#27862)
  [Elastic Agent] Disable modules.d in metricbeat (elastic#27860)
  libbeat/common/seccomp: provide default policy for linux arm64 (elastic#27955)
  Fix logger statement in aws-s3 input (elastic#27982)
  Fix wrong merge (elastic#27976)
  Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969)
  Forward-port 7.14.2 changelog to master (elastic#27975)
  [Filebeat] Removing duplicate modules (aliases) Observability (elastic#27919)
  Fix path in vagrant windows script (elastic#27966)
  [Filebeat] Removing duplicate modules (aliases) and Cyberark (elastic#27915)
  No changelog for 8.0.0-alpha2 (elastic#27961)
  Add write access to 'url.value' from 'request.transforms'. (elastic#27937)
  Docker: remove deprecated fields (elastic#27933)
  Filebeat: Make all filesets disabled in default configuration (elastic#27762)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@marc-gr
Add write access to 'url.value' from 'request.transforms'. (elastic#2…
c27c187 
…7937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
backport-v7.16.0 Automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @P1llus