Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osquerybeat: Fix 7.15 extension start failure on windows #27868

Merged

Conversation

aleksmaus
Copy link
Contributor

What does this PR do?

Fixes the issue reported on windows, where our extension server client fails to connect to the osqueryd named pipe.

[elastic_agent.osquerybeat][error] Failed to run osqueryd: dialing pipe '\\.\pipe\elastic\osquery\d4501c4e-98f2-454c-8e46-e61b4f9a898d': open \\.\pipe\elastic\osquery\d4501c4e-98f2-454c-8e46-e61b4f9a898d: The system cannot find the file specified.

The issue is due to the change on July 8th, where the sequence of the osqueryd startup was changed. This changed the sequence back to:

  1. start osqueryd
  2. connect the osquery client to osqueryd (with retires)
  3. start extensions server for our own config and logging plugins

The osquery client connection with retries before starting the extensions server guarantees that the osqueryd is running with the given named pipe.

Why is it important?

Fixes the issue with osquerybeat 7.15 on Windows.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

@aleksmaus aleksmaus added bug Team:Asset Mgt v7.15.0 backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Sep 10, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 10, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-10T16:32:52.019+0000

  • Duration: 53 min 47 sec

  • Commit: 3e76d59

Test stats 🧪

Test Results
Failed 0
Passed 3888
Skipped 0
Total 3888

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3888
Skipped 0
Total 3888

@aleksmaus aleksmaus merged commit 537f403 into elastic:master Sep 10, 2021
mergify bot pushed a commit that referenced this pull request Sep 10, 2021
mergify bot pushed a commit that referenced this pull request Sep 10, 2021
aleksmaus added a commit that referenced this pull request Sep 10, 2021
…7872)

(cherry picked from commit 537f403)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
aleksmaus added a commit that referenced this pull request Sep 10, 2021
…7871)

(cherry picked from commit 537f403)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify bug Team:Asset Mgt v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants