Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LIBBEAT_MONITORING_CGROUPS_HIERARCHY_OVERRIDE to system/process #27700

Merged

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

So, a while ago @axw added support for LIBBEAT_MONITORING_CGROUPS_HIERARCHY_OVERRIDE in libbeat monitoring. However, it wasn't added to system/process. I'm going to assume it was just overlooked, and there wasn't a reason to exclude it, so this adds it, so we get proper cgroup metrics from a container.

Why is it important?

This is kind of a bug, as we properly report cgroup metrics within libbeat monitoring, but not within metricbeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Pull down and build
  • Run metricbeat inside a container, make sure cgroup metrics are correctly reported from within system/process

@fearful-symmetry fearful-symmetry added bug Team:Integrations Label for the Integrations team backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Sep 2, 2021
@fearful-symmetry fearful-symmetry requested review from axw and a team September 2, 2021 00:00
@fearful-symmetry fearful-symmetry self-assigned this Sep 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 2, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-02T00:00:58.228+0000

  • Duration: 84 min 41 sec

  • Commit: 38de8fb

Test stats 🧪

Test Results
Failed 0
Passed 9171
Skipped 2429
Total 11600

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9171
Skipped 2429
Total 11600

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I originally only added for stack monitoring as that's all we needed, but I think it's sensible to apply it to regular system metrics too.

@fearful-symmetry fearful-symmetry merged commit 75b1ff7 into elastic:master Sep 2, 2021
mergify bot pushed a commit that referenced this pull request Sep 2, 2021
mergify bot pushed a commit that referenced this pull request Sep 2, 2021
fearful-symmetry added a commit that referenced this pull request Sep 2, 2021
…27700) (#27716)

(cherry picked from commit 75b1ff7)

Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com>
fearful-symmetry added a commit that referenced this pull request Sep 2, 2021
…27700) (#27715)

(cherry picked from commit 75b1ff7)

Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify bug Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants