-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LIBBEAT_MONITORING_CGROUPS_HIERARCHY_OVERRIDE to system/process #27700
Add LIBBEAT_MONITORING_CGROUPS_HIERARCHY_OVERRIDE to system/process #27700
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I originally only added for stack monitoring as that's all we needed, but I think it's sensible to apply it to regular system metrics too.
What does this PR do?
So, a while ago @axw added support for
LIBBEAT_MONITORING_CGROUPS_HIERARCHY_OVERRIDE
in libbeat monitoring. However, it wasn't added to system/process. I'm going to assume it was just overlooked, and there wasn't a reason to exclude it, so this adds it, so we get proper cgroup metrics from a container.Why is it important?
This is kind of a bug, as we properly report cgroup metrics within libbeat monitoring, but not within metricbeat.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
system/process