Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] fix the inject_headers transpiler rule #27481

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

faec
Copy link
Contributor

@faec faec commented Aug 18, 2021

What does this PR do?

Fix the inject_headers transpiler rule that adds fleet enrollment metadata into the http headers of resulting beats clients. The rule attempted (and silently failed) to inject the headers into the configuration under the outputs node, but at the rule application stage configurations are normalized to use an output node instead.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added bug Team:Elastic-Agent Label for the Agent team labels Aug 18, 2021
@faec faec self-assigned this Aug 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 18, 2021
@faec faec requested a review from blakerouse August 18, 2021 22:17
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-18T21:13:56.029+0000

  • Duration: 80 min 30 sec

  • Commit: 6fc698d

Test stats 🧪

Test Results
Failed 0
Passed 7028
Skipped 16
Total 7044

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7028
Skipped 16
Total 7044

@ruflin
Copy link
Collaborator

ruflin commented Aug 19, 2021

What are the side effects this bug had? Anything in Cloud?

Does this need backports?

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

This needs to be backported to 7.14.

@ruflin This means that any headers that cloud was expecting to get from the beats that are ran by agent, they were not getting them.

@faec faec added backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Aug 19, 2021
@faec faec merged commit 4b442ce into elastic:master Aug 19, 2021
@faec faec deleted the agent-inject_headers branch August 19, 2021 14:21
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
faec added a commit that referenced this pull request Aug 19, 2021
(cherry picked from commit 4b442ce)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
faec added a commit that referenced this pull request Aug 19, 2021
(cherry picked from commit 4b442ce)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
faec added a commit that referenced this pull request Aug 19, 2021
(cherry picked from commit 4b442ce)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify bug Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants