-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[agent] fix the inject_headers transpiler rule #27481
Conversation
Pinging @elastic/agent (Team:Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
What are the side effects this bug had? Anything in Cloud? Does this need backports? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
This needs to be backported to 7.14.
@ruflin This means that any headers that cloud was expecting to get from the beats that are ran by agent, they were not getting them.
(cherry picked from commit 4b442ce)
(cherry picked from commit 4b442ce)
(cherry picked from commit 4b442ce)
What does this PR do?
Fix the
inject_headers
transpiler rule that adds fleet enrollment metadata into the http headers of resulting beats clients. The rule attempted (and silently failed) to inject the headers into the configuration under theoutputs
node, but at the rule application stage configurations are normalized to use anoutput
node instead.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.