Fix used memory calculations in docker/memory #27473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
| "max": 7860224, | ||
| "pct": 0.000672283359618831, | ||
| "total": 1409024 | ||
| "max": 0, |
There was a problem hiding this comment.
Does this 0 look right to you?
There was a problem hiding this comment.
This is a case where V1 and V2 might be different. Max Just indicates the cgroup's upper threshold, with 0 meaning there is no upper limit.
Do you want to backport this to 7.15? 🙂 |
|
@jsoriano Added the correct (I think) backport tags. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
(cherry picked from commit 3365e67)
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
(cherry picked from commit 3365e67)
fearful-symmetry
added a commit
that referenced
this pull request
Aug 23, 2021
fearful-symmetry
added a commit
that referenced
this pull request
Aug 23, 2021
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This brings the memory usage reporting for
docker/memoryin line withdocker stat, as well ascadvisorandcontainerdby calculating used memory asused - inactive_file. I'm marking this a bug, since we were the only ones using this more simplistic usage calculation.Why is it important?
This brings us in line with how container memory usage is calculated elsewhere.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
usageindocker/memoryis a reasonable value.Related issues