Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default evenhub settings for each log type #27459

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

insukcho
Copy link
Contributor

What does this PR do?

When we only put one default eventhub settings in this reference, the user might be confused they can use a single eventhub for all event types even the field mappings and parsing logic are different. Let's add all default settings with the notes that the user needs to understand each log type has different fields, expicitly.

Why is it important?

The user could use one single eventhub and having trouble when the logs are parsed from Elasticsearch side.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

When we only put one default eventhub settings in this reference, the user might be confused they can use a single eventhub for all event types even the field mappings and parsing logic are different. Let's add all default settings with the notes that the user needs to understand each log type has different fields, expicitly.
@insukcho insukcho added docs Team:Docs Label for the Observability docs team labels Aug 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 18, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 18, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-19T18:36:11.059+0000

  • Duration: 21 min 22 sec

  • Commit: f9e6464

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Insuk! I'll get this merged and cherry-picked once the tests are green.

@bmorelli25 bmorelli25 self-assigned this Aug 19, 2021
@bmorelli25
Copy link
Member

OK, I think I fixed the lint issues. This is a generated file, so the change has to be made in the source file and propagated with make update. 🤞

@bmorelli25 bmorelli25 merged commit 2196747 into 7.14 Aug 19, 2021
@bmorelli25 bmorelli25 deleted the eventhub-doc-enhancement-request branch August 19, 2021 19:40
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Aug 19, 2021
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Aug 19, 2021
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Aug 19, 2021
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
bmorelli25 added a commit that referenced this pull request Aug 23, 2021
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

Co-authored-by: Insuk (Chris) Cho <isi.cho@gmail.com>
bmorelli25 added a commit that referenced this pull request Aug 23, 2021
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

Co-authored-by: Insuk (Chris) Cho <isi.cho@gmail.com>
bmorelli25 added a commit that referenced this pull request Aug 23, 2021
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

Co-authored-by: Insuk (Chris) Cho <isi.cho@gmail.com>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
…ic#27510)

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

Co-authored-by: Insuk (Chris) Cho <isi.cho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants