Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Fixes for Snyk API changes #27358

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Aug 13, 2021

What does this PR do?

This adds fixes for certain API changes for the Snyk module, moving to another way of paginating, and some of the filters have been adjusted.

Why is it important?

Required for the module to continue working with the new API changes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Tests has been done against our own Snyk account to confirm changes is working as intended

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 13, 2021
@marc-gr marc-gr added backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Aug 13, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-13T08:47:26.949+0000

  • Duration: 103 min 16 sec

  • Commit: 716dbfb

Test stats 🧪

Test Results
Failed 0
Passed 7890
Skipped 1201
Total 9091

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7890
Skipped 1201
Total 9091

@P1llus P1llus merged commit 3925601 into elastic:master Aug 13, 2021
mergify bot pushed a commit that referenced this pull request Aug 13, 2021
* adding fixes for pagination for snyk

* adding changelog entry

(cherry picked from commit 3925601)
mergify bot pushed a commit that referenced this pull request Aug 13, 2021
* adding fixes for pagination for snyk

* adding changelog entry

(cherry picked from commit 3925601)
P1llus added a commit that referenced this pull request Aug 13, 2021
* adding fixes for pagination for snyk

* adding changelog entry

(cherry picked from commit 3925601)

Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
P1llus added a commit that referenced this pull request Aug 13, 2021
* adding fixes for pagination for snyk

* adding changelog entry

(cherry picked from commit 3925601)

Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.15 Candidate backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify
Projects
None yet
3 participants