Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for web identity provider in aws #27126

Merged
merged 20 commits into from
Aug 11, 2021
Merged

Add support for web identity provider in aws #27126

merged 20 commits into from
Aug 11, 2021

Conversation

aspacca
Copy link

@aspacca aspacca commented Jul 29, 2021 •
edited
Loading

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes #19393

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 29, 2021
@aspacca aspacca added the Team:Integrations Label for the Integrations team label Jul 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 29, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 29, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-11T14:39:24.820+0000

  • Duration: 200 min 28 sec

  • Commit: 80b95b3

Test stats 🧪

Test Results
Failed 0
Passed 52811
Skipped 5297
Total 58108

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 52811
Skipped 5297
Total 58108

@kaiyan-sheng kaiyan-sheng mentioned this pull request Jul 29, 2021
Closed
6 tasks
@aspacca aspacca mentioned this pull request Jul 29, 2021
Closed
@aspacca
Copy link
Author

aspacca commented Aug 5, 2021

/test

1 similar comment
@aspacca
Copy link
Author

aspacca commented Aug 10, 2021

/test

@aspacca
Copy link
Author

aspacca commented Aug 11, 2021

/test

@aspacca aspacca mentioned this pull request Aug 11, 2021
Closed
kaiyan-sheng
kaiyan-sheng approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kaiyan-sheng
kaiyan-sheng reviewed Aug 11, 2021
View reviewed changes
CHANGELOG.next.asciidoc Outdated
@@ -99,6 +99,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Added `statsd.mappings` configuration for Statsd module {pull}26220[26220]
- Added Airflow lightweight module {pull}26220[26220]
- Add state_job metricset to Kubernetes module{pull}26479[26479]
- Recover service.address field in vsphere module {issue}26902[26902] {pull}26904[26904]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra changelog entry

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 👍

@aspacca aspacca mentioned this pull request Aug 11, 2021
Merged
11 tasks
@aspacca aspacca added the backport-v7.15.0 Automated backport with mergify label Aug 11, 2021
@aspacca aspacca merged commit b715d69 into elastic:master Aug 11, 2021
mergify bot pushed a commit that referenced this pull request Aug 11, 2021
Add support for web identity provider in aws (#27126)
8c1e3fe 
* Add support for web identity provider in AWS

(cherry picked from commit b715d69)
@mergify mergify bot mentioned this pull request Aug 11, 2021
Merged
aspacca pushed a commit that referenced this pull request Aug 12, 2021
@mergify
Add support for web identity provider in aws (#27126) (#27320)
7e43fd9 
* Add support for web identity provider in AWS

(cherry picked from commit b715d69)

Co-authored-by: Andrea Spacca <andrea.spacca@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport-v7.15.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Add support for IAM Roles for Service Accounts (EKS)
3 participants
@aspacca @elasticmachine @kaiyan-sheng