-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cluster filter on Kubernetes Overview ECS dashboard #26919
Conversation
💚 CLA has been signed |
d4bc469
to
d4deed4
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, thanks for working on this @akshay-saraswat but I think the Dashboard screenshot needs to be replaced with a more representative one displaying nodes, deployments, etc as well as the usage of the cluster filter.
99082eb
to
7df424b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Feel free to merge it once CI is green (I think you need to sign the CLA).
Pinging @elastic/integrations (Team:Integrations) |
7df424b
to
a1540a2
Compare
(cherry picked from commit 25f4091)
(cherry picked from commit 25f4091)
Dashboard added here has some kind of issue,
It may be because it uses version 7.14.0 that hasn't been released yet, but not sure. Why wasn't this detected by CI? These were the logs there:
It seems that selective testing was triggered as only one module was modified, and no test was executed in this case. @ChrsMark @akshay-saraswat could you please review this dashboard? |
@jsoriano I think that Dashboard is ok. The backports to 7.x and 7.14 should work with 7.14 compatible Dasboards. I think that we miss the update of the testing stack, sth like #24957. |
But |
I think that The weird thing is that this PR was green at https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-26919/5/pipeline, 🤔 . In any case we need to update beats/metricbeat/docker-compose.yml Line 40 in 7f41ce0
|
Yes, this is what I mention in #26919 (comment), it seems it was not detected in CI because only the python tests for kubernetes were executed, what doesn't include
I am looking now at how we can make dashboards tests to be executed for modules too.
We cannot do this change till 7.14 is released. I think we need to revert the change on this dashboard, or make it work with the current tested versions. If not we are going to have broken builds till the release of 7.14. |
* master: Forward port 7.13.4 to master (elastic#26971) Use MustAddMetricSet in all metricsets (elastic#26907) add_process_metadata: enrich process info with process owner (elastic#21068) (elastic#21111) Use aws sdk paginator for FilterLogEvents and GetMetricData (elastic#26852) [Filebeat] Allow - for source IP for AWS S3 Access pipeline (elastic#26940) Increase timeout to 30secs (elastic#26841) Add Cluster filter on Kubernetes Overview ECS dashboard (elastic#26919)
What does this PR do?
Added a Cluster name selector on the
[Metricbeat Kubernetes] Overview ECS
dashboard. This selector will be used as a filter for the dashboard. Also, added a blur for this selector on the Kubernetes module documentation page to explain how this selector works and where it sources the data from. Added a screenshot of the[Metricbeat Kubernetes] Overview ECS
dashboard on the Kubernetes module documentation page because we need a visual to explain the Cluster filter.Why is it important?
We have added a new Cluster name field in metricbeat. this field will not be useful unless users could discover it in some form
in UI.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Screenshots