-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] ASA Ingest Pipeline fixes #26879
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
/test |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
x-pack/filebeat/module/cisco/shared/ingest/asa-ftd-pipeline.yml
Outdated
Show resolved
Hide resolved
There are also a few message-ids where the various *.user.name fields include the surrounding brackets. Some like 302013, 302020 don't include the brackets. |
There aren't any sample logs with those message IDs that include the optional username. Can you provide some so we can test that? |
106023: 302020: |
https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslog-messages-302003-to-342008.html#con_4770598 Message-id 305012 is not included in the ingress pipeline, however I have noticed that a similar message-id 302012 is present. I can see 305012 message ids in the test logs but its not in the ingress pipeline. I think the pattern for 302012 in the ingress pipeline should be for 305012. |
I think you're right. Fixed. |
message-id 302020 gets incorrectly tagged with event.action: flow-expiration when the message referrers to building a icmp connection. 609001 is also another message id that gets tagged with flow-expiration but refers to building a connection. message ids that refer to building connections (such as 302013) get tagged as event.action: "firewall-rule". This is applied because event.id is not blank. It maybe more informational if the event.action refers to the built / teardown actions in the log messages. Or perhaps these were meant to be tagged with connection-started? |
https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslog-messages-302003-to-342008.html#con_4770603 Example: This message id has the AAA user at the end and no destination user. This gets picked up by the ingress pipeline as the destination username when in fact the destination has no user. I'd expect the destination user, similar to the source user, to be right after the destination port with no space in between. I think this gets picked up because theres a space before the bracket in the destination user pattern. Quite the Goliathan task parsing these Cisco Syslog messages. |
Does it make sense to keep the |
I believe it maybe worth keeping. Its possible other deployments out there are authenticating differently and it'll show the correct domain. I'm certain its down to how we have deployed and configured Cisco Identity Services Engine and/or Cisco Context Directory Agent. https://www.cisco.com/c/en/us/td/docs/security/ibf/cda_10/Install_Config_guide/cda10/cda_wrkng.html
|
Copy. I'll have to go back and take some time to make sure its all parsed properly. |
For message id 733100 Examples:
|
@trexx My latest commit should address everything ( I think). Please take a look and let me know. If there is more sample data that you think we should add to identifies these pattern issues, please post them. |
x-pack/filebeat/module/cisco/asa/test/hostnames.log-expected.json
Outdated
Show resolved
Hide resolved
d199667
to
9b2be6e
Compare
@legoguy1000 All good. No more grok errors. *.users look good too. |
Oh looks like there's a mapping error in my logs. Failed to parse field [source.port] of type [long] |
Which log I'd was that and can u post the original log? |
The dissect for message-id 305012 is missing patterns to detect user name, it was renamed from message id 302012. This was causing "mapper_parsing_exception"s
Its structure is similar to that of message id 305011 which is the "Built" event and is matching user names. |
This pull request is now in conflicts. Could you fix it? 🙏
|
Yes. All issues have been solved with these changes. |
@legoguy1000 Now that the issues has been resolved, is this now ready to be reviewed? |
80161bd
to
5f4c04b
Compare
Yes I think so. |
jenkins run tests |
* #26869: ASA Ingest Pipeline fixes * Update changelog * Update 106023 & 302016 grok patterns * Update addtional grok patterns per comments * Fix per comment * update fields from master * Updated via last comment * Update pipeline * update pipeline to address #27137 (cherry picked from commit 5bc8572)
@P1llus This will need to be synced with the integrations |
* #26869: ASA Ingest Pipeline fixes * Update changelog * Update 106023 & 302016 grok patterns * Update addtional grok patterns per comments * Fix per comment * update fields from master * Updated via last comment * Update pipeline * update pipeline to address #27137 (cherry picked from commit 5bc8572) Co-authored-by: Alex Resnick <adr8292@gmail.com>
* elastic#26869: ASA Ingest Pipeline fixes * Update changelog * Update 106023 & 302016 grok patterns * Update addtional grok patterns per comments * Fix per comment * update fields from master * Updated via last comment * Update pipeline * update pipeline to address elastic#27137
What does this PR do?
Modifies the cisco ASA FTD Ingest pipeline
community_id
processornetwork.transport
source.user.*
fieldsnetwork.iana_number
is present instead ofnetwork.transport
network.inner
usageWhy is it important?
Grok/dissect patterns aren't correct.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs