Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_workspace] Use fingerprint to generate fixed document id to avoid having duplicates #25841

Merged
merged 1 commit into from
May 26, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 25, 2021

What does this PR do?

Adds a fingerprint processor to generate fixed document ids.

Why is it important?

To avoid generating duplicate events.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 25, 2021
@mergify
Copy link
Contributor

mergify bot commented May 25, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gw_fingerprint upstream/gw_fingerprint
git merge upstream/master
git push upstream gw_fingerprint

@marc-gr marc-gr added the backport-v7.14.0 Automated backport with mergify label May 25, 2021
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25841 updated

  • Start Time: 2021-05-26T07:19:54.197+0000

  • Duration: 107 min 29 sec

  • Commit: f7c8a30

Test stats 🧪

Test Results
Failed 0
Passed 7193
Skipped 1193
Total 8386

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7193
Skipped 1193
Total 8386

@mergify
Copy link
Contributor

mergify bot commented May 25, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gw_fingerprint upstream/gw_fingerprint
git merge upstream/master
git push upstream gw_fingerprint

@marc-gr marc-gr merged commit 4065dfd into elastic:master May 26, 2021
@marc-gr marc-gr deleted the gw_fingerprint branch May 26, 2021 10:03
mergify bot pushed a commit that referenced this pull request May 26, 2021
marc-gr added a commit that referenced this pull request May 26, 2021
…tes (#25841) (#25866)

(cherry picked from commit 4065dfd)

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants