Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[winlogbeat/libbeat] Change event.code and winlog.event_id type #25176

Merged
merged 1 commit into from
Apr 21, 2021
Merged

[winlogbeat/libbeat] Change event.code and winlog.event_id type #25176

merged 1 commit into from
Apr 21, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Apr 20, 2021 •
edited
Loading

What does this PR do?

Changes event.code and winlog.event_id from int to keyword.

Why is it important?

To be consistent with the expected ECS type.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr requested a review from leehinman April 20, 2021 14:33
@marc-gr marc-gr requested a review from a team as a code owner April 20, 2021 14:33
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr force-pushed the fix_winlog_event_code branch from c76606a to ecc2dff Compare April 20, 2021 14:45
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 20, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: marc-gr commented: /test

  • Start Time: 2021-04-21T11:16:07.011+0000

  • Duration: 27 min 21 sec

  • Commit: 9f399c7

Test stats 🧪

Test Results
Failed 0
Passed 542
Skipped 5
Total 547

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 542
Skipped 5
Total 547

@marc-gr marc-gr force-pushed the fix_winlog_event_code branch 2 times, most recently from eb444ac to 5e5bcf2 Compare April 21, 2021 07:14
@marc-gr marc-gr force-pushed the fix_winlog_event_code branch from 5e5bcf2 to 9f399c7 Compare April 21, 2021 07:55
@marc-gr
Copy link
Contributor Author

marc-gr commented Apr 21, 2021

/test

3 similar comments
@marc-gr
Copy link
Contributor Author

marc-gr commented Apr 21, 2021

/test

@marc-gr
Copy link
Contributor Author

marc-gr commented Apr 21, 2021

/test

@marc-gr
Copy link
Contributor Author

marc-gr commented Apr 21, 2021

/test

@marc-gr marc-gr added the backport-v7.14.0 Automated backport with mergify label Apr 21, 2021
@marc-gr marc-gr merged commit ee5ed90 into elastic:master Apr 21, 2021
@marc-gr marc-gr deleted the fix_winlog_event_code branch April 21, 2021 11:44
@marc-gr marc-gr removed backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels Apr 21, 2021
@marc-gr marc-gr mentioned this pull request Apr 21, 2021
Merged
4 tasks
@marc-gr marc-gr mentioned this pull request Apr 21, 2021
Merged
4 tasks
v1v added a commit to v1v/beats that referenced this pull request Apr 21, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/customise…
d6c9e5c 
…-github-pr-comment-template

* upstream/master:
  Check native environment before starting (elastic#25186)
  Change event.code and winlog.event_id type (elastic#25176)
  [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193)
  Update mergify backporting to 7.x and 7.13 (elastic#25196)
  [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites  * address review and fix notice  * fix lowercase struct  * fix version conflict and rebase  * update go.* stuff to master  * fix notice.txt  * move validate inside sourcempatability for suites (elastic#24777)
  [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101)
  Update replace.asciidoc (elastic#25055)
  Fix nil panic when overwriting metadata (elastic#24741)
  [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570)
  Fix k8s svc selectors mapping (elastic#25169)
  [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163)
  [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113)
v1v added a commit to v1v/beats that referenced this pull request Apr 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/pin-testi…
82ffbd4 
…ng-versions-stack

* upstream/master: (28 commits)
  Add support for parsers in filestream input (elastic#24763)
  Skip flaky test TestFilestreamTruncate (elastic#25218)
  backport: Add 7.13 branch (elastic#25189)
  Update decode_json_fields.asciidoc (elastic#25056)
  [Elastic Agent] Fix status and inspect command to work inside running container (elastic#25204)
  Check native environment before starting (elastic#25186)
  Change event.code and winlog.event_id type (elastic#25176)
  [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193)
  Update mergify backporting to 7.x and 7.13 (elastic#25196)
  [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites  * address review and fix notice  * fix lowercase struct  * fix version conflict and rebase  * update go.* stuff to master  * fix notice.txt  * move validate inside sourcempatability for suites (elastic#24777)
  [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101)
  Update replace.asciidoc (elastic#25055)
  Fix nil panic when overwriting metadata (elastic#24741)
  [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570)
  Fix k8s svc selectors mapping (elastic#25169)
  [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163)
  [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113)
  [Ingest Manager] Keep http and logging config during enroll (elastic#25132)
  Refactor kubernetes autodiscover to avoid skipping short-living pods (elastic#24742)
  [libbeat] New decode xml wineventlog processor (elastic#25115)
  ...
marc-gr added a commit to marc-gr/beats that referenced this pull request Apr 26, 2021
@marc-gr
Change event.code and winlog.event_id type (elastic#25176)
b095777 
(cherry picked from commit ee5ed90)
marc-gr added a commit to marc-gr/beats that referenced this pull request Apr 26, 2021
@marc-gr
Change event.code and winlog.event_id type (elastic#25176)
b1eac35 
(cherry picked from commit ee5ed90)
marc-gr added a commit that referenced this pull request Apr 26, 2021
@marc-gr
Change event.code and winlog.event_id type (#25176) (#25203)
ac25703 
(cherry picked from commit ee5ed90)
marc-gr added a commit that referenced this pull request Apr 26, 2021
@marc-gr @elasticmachine
Cherry-pick #25176 to 7.x: [winlogbeat/libbeat] Change event.code and…
d75401c 
… winlog.event_id type (#25202)

* docs: update docs

* chore: update test environment

* fix: make update changes

* Change event.code and winlog.event_id type (#25176)

(cherry picked from commit ee5ed90)

Co-authored-by: elasticmachine <infra-root+elasticmachine@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@leehinman leehinman Awaiting requested review from leehinman

Assignees
No one assigned
Labels
bug v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @andrewkroh