Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #25074 to 7.x: [Filebeat][httpjson] Change append transform to initiate new fields as a slice #25088

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Apr 14, 2021

Cherry-pick of PR #25074 to 7.x branch. Original message:

What does this PR do?

Currently the append transform for httpjson only creates an array/list/slice once at least 2 values has been appended to a specific field. This creates a situation in which there is no possibilities with any transform, to create a list object that only has a single value.

Why is it important?

Allows users that communicates with API's that requires single value lists as a key/value pair.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…s a slice (elastic#25074)

* changing the append processor to create a single value as list, not only if two or more values are added

* removing mistake typo

* add changelog entry

(cherry picked from commit 2b11cf8)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 14, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25088 updated

  • Start Time: 2021-04-14T15:38:03.912+0000

  • Duration: 62 min 27 sec

  • Commit: 557def9

Test stats 🧪

Test Results
Failed 0
Passed 6892
Skipped 1185
Total 8077

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6892
Skipped 1185
Total 8077

@P1llus P1llus merged commit 92d0808 into elastic:7.x Apr 16, 2021
@zube zube bot removed the [zube]: Done label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants