Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24719 to 7.12: [Filebeat] Fix gcp/vpcflow module defaulting to file input #24734

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 24, 2021

Cherry-pick of PR #24719 to 7.12 branch. Original message:

What does this PR do?

The pubsub input was renamed from google-pubsub to gcp-pubsub and the vpcflow filesets manifest
was not updated. As a result it's defaulting to the file input. This fixes the manifest.

The workaround is to explicitly set the input type:

vpcflow:
  enabled: true
  var.input: gcp-pubsub

Why is it important?

The input won't start using existing configurations causing a breaking change.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Logs

Exiting: Failed to start crawler: starting input failed: Error while initializing input: No paths were defined for input accessing config

The pubsub input was renamed from google-pubsub to gcp-pubsub and the vpcflow filesets manifest
was not updated. As a result it's defaulting to the file input. This fixes the manifest.

The workaround is to explicitly set the input type:

    vpcflow:
      enabled: true
      var.input: gcp-pubsub

(cherry picked from commit 4f91947)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 24, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 24, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24734 updated

  • Start Time: 2021-03-24T15:11:29.857+0000

  • Duration: 132 min 39 sec

  • Commit: b334849

Test stats 🧪

Test Results
Failed 0
Passed 6814
Skipped 1153
Total 7967

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6814
Skipped 1153
Total 7967

@andrewkroh andrewkroh merged commit cc7b7d8 into elastic:7.12 Mar 24, 2021
@zube zube bot removed the [zube]: Done label Jun 23, 2021
@andrewkroh andrewkroh deleted the backport_24719_7.12 branch January 14, 2022 14:05
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…defaulting to file input (elastic#24734)

The pubsub input was renamed from google-pubsub to gcp-pubsub and the vpcflow filesets manifest
was not updated. As a result it's defaulting to the file input. This fixes the manifest.

The workaround is to explicitly set the input type:

    vpcflow:
      enabled: true
      var.input: gcp-pubsub

(cherry picked from commit c5ef8ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants