Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24502 to 7.x: Update gosigar package after fix #24626

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 18, 2021

Cherry-pick of PR #24502 to 7.x branch. Original message:

What does this PR do?

Described here elastic/gosigar#159

Why is it important?

Described here elastic/gosigar#159

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

* mofidy doc

* work on fix

* update changelog

* update notice

* Update notice

* [Ingest Manager] Sync on rename on windows (elastic#24504)

* Add tests for encoding settings of filestream input (elastic#24426)

* [Elastic Agent] Add the ability to provide custom CA's inside of docker. (elastic#24486)

* Add the ability to provide custom CA's for Elastic Agent docker.

* Add changelog.

* Update Golang to 1.15.9 (elastic#24442)

* Add syntax for multiple selector logging (elastic#24207) (elastic#24497)

* Add syntax for multiple selector logging

* Update libbeat/docs/loggingconfig.asciidoc

Co-authored-by: EamonnTP <Eamonn.Smith@elastic.co>

Co-authored-by: EamonnTP <Eamonn.Smith@elastic.co>

Co-authored-by: AndyHunt66 <andrew.hunt@elastic.co>

* chore(ci): use beat_version instead of PR version (elastic#24446)

* Add test for close.reader.after_interval to filestream input (elastic#24423)

* Refactor use of system.hostfs to fix cgroup metrics (elastic#24334)

* refactor use of system.hostfs to fix cgroup metrics

* add changelog

* remove comment

* add cfgwarn

* move changelog

* shift around CLI config location and rep warning

* add comment about system.hostfs usage

* update docs

* capitalization

* fix grammar, add conditional

* change docs phrasing

* [Elastic Agent] Add verification check when updating communication to Kibana. (elastic#24489)

* Add verification check when updating communication to Kibana.

* Add changelog.

* Add const.

* Fix typo in mqtt input docs (elastic#24509)

* Update input-http-endpoint.asciidoc (elastic#24490)

* [Ingest Manager] Move logging defaults to agent (elastic#24535)

[Ingest Manager] Move logging defaults to agent (elastic#24535)

* Clarify that the Tomcat module is for ingesting access logs (elastic#24543)

The Tomcat module is for ingesting access logs, not Catalina or localhost logs.

* [Auditbeat] btmp offset check (elastic#24515)

* auditbeat btmp offset check

Add check that saved offset is not larger than the current file size
to prevent seeking past the end of file

* [Heartbeat] Produce error rather than panic on missing source (elastic#24404)

Fixes elastic#24403.

With the changes to the heartbeat config syntax in 7.12 the `source`
field is now required. Our config validation code didn't actually check
for this field's presence, which caused an NPE.

This PR adds a validation checking for that config's presence. It also
adds tests for the validation code for config sub-fields. There were no
defects found in the validations for source.inline, or source.browser,
but a few tests were missing.

Instead of the panic seen in elastic#24403 users will now get the error seen
below.

```
2021-03-05T15:41:40.146-0600	ERROR	instance/beat.go:952	Exiting: could not create monitor: job err could not parse suite config: config 'source' must be specified for this monitor, if upgrading from a previous experimental version please see our new config docs accessing 'heartbeat.monitors.0' (source:'sample-synthetics-config/heartbeat.yml')
Exiting: could not create monitor: job err could not parse suite config: config 'source' must be specified for this monitor, if upgrading from a previous experimental version please see our new config docs accessing 'heartbeat.monitors.0' (source:'sample-synthetics-config/heartbeat.yml')
```

* Fix default scope in add_nomad_metadata (elastic#24559)

Fix default scope in add_nomad_metadata. It is set to local, but
it should be node. Fix also error message that showed that local
is a valid value.

* [Filebeat] Add Dashboards to Threat Intel Module (elastic#24488)

* added dashboards & docs

* ran mage fmt update

* [CI] bump gvm version and use the binary (elastic#24571)

* [CI] Add resilience when installing required tooling (elastic#24542)

* [CI] enable new flaky detector (elastic#24464)

* chore: do not pass beat version (elastic#24586)

We will be delegating the version calculation to the e2e tests, using
target branch values as defaults

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Co-authored-by: EamonnTP <Eamonn.Smith@elastic.co>
Co-authored-by: AndyHunt66 <andrew.hunt@elastic.co>
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Co-authored-by: Lee Hinman <57081003+leehinman@users.noreply.github.com>
Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Co-authored-by: Andrew Pease <7442091+peasead@users.noreply.github.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
(cherry picked from commit 5c6f1b6)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2021
@narph narph changed the title Cherry-pick to 7.x: Update gosigar package after fix Cherry-pick #24502 to 7.x: Update gosigar package after fix Mar 18, 2021
@narph narph self-assigned this Mar 18, 2021
@narph narph added backport Team:Integrations Label for the Integrations team labels Mar 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2021

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: Pull request #24626 updated

  • Start Time: 2021-03-25T08:18:28.379+0000

  • Duration: 182 min 57 sec

  • Commit: ba578c6

Test stats 🧪

Test Results
Failed 0
Passed 46132
Skipped 5144
Total 51276

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 1

Expand to view the steps failures

libbeat-build - Install Go/Mage/Python/Docker/Terraform 1.15.9
  • Took 0 min 10 sec . View more details on here
  • Description: .ci/scripts/install-tools.sh

Log output

Expand to view the last 100 lines of log output

[2021-03-25T09:35:38.266Z]   ### END ENV DUMP ###
[2021-03-25T09:35:38.266Z]   
[2021-03-25T09:35:38.277Z] Running in /var/lib/jenkins/workspace/PR-24626-10-2473d663-2d32-4db7-95e9-60c9ba43dfdd/src/github.com/elastic/beats/x-pack/packetbeat
[2021-03-25T09:35:38.587Z] + mage check
[2021-03-25T09:35:45.170Z] >> fmt - go-licenser: Adding missing headers
[2021-03-25T09:35:45.170Z] >> fmt - goimports: Formatting Go code
[2021-03-25T09:35:47.084Z] Generated fields.yml for packetbeat to /var/lib/jenkins/workspace/PR-24626-10-2473d663-2d32-4db7-95e9-60c9ba43dfdd/src/github.com/elastic/beats/x-pack/packetbeat/fields.yml
[2021-03-25T09:35:47.084Z] >> Building packetbeat.yml for linux/amd64
[2021-03-25T09:35:47.084Z] >> Building packetbeat.reference.yml for linux/amd64
[2021-03-25T09:35:47.084Z] >> Building packetbeat.docker.yml for linux/amd64
[2021-03-25T09:35:47.084Z] >> check: Checking source code for common problems
[2021-03-25T09:36:55.123Z] + mage update
[2021-03-25T09:36:55.123Z] Generated fields.yml for packetbeat to /var/lib/jenkins/workspace/PR-24626-10-2473d663-2d32-4db7-95e9-60c9ba43dfdd/src/github.com/elastic/beats/x-pack/packetbeat/fields.yml
[2021-03-25T09:36:55.123Z] >> Building packetbeat.yml for linux/amd64
[2021-03-25T09:36:55.123Z] >> Building packetbeat.reference.yml for linux/amd64
[2021-03-25T09:36:55.123Z] >> Building packetbeat.docker.yml for linux/amd64
[2021-03-25T09:36:55.494Z] Cleaning up /var/lib/jenkins/workspace/PR-24626-10-2473d663-2d32-4db7-95e9-60c9ba43dfdd
[2021-03-25T09:36:55.494Z] Client: Docker Engine - Community
[2021-03-25T09:36:55.494Z]  Version:           20.10.3
[2021-03-25T09:36:55.494Z]  API version:       1.41
[2021-03-25T09:36:55.494Z]  Go version:        go1.13.15
[2021-03-25T09:36:55.494Z]  Git commit:        48d30b5
[2021-03-25T09:36:55.495Z]  Built:             Fri Jan 29 14:33:13 2021
[2021-03-25T09:36:55.495Z]  OS/Arch:           linux/amd64
[2021-03-25T09:36:55.495Z]  Context:           default
[2021-03-25T09:36:55.495Z]  Experimental:      true
[2021-03-25T09:36:55.495Z] 
[2021-03-25T09:36:55.495Z] Server: Docker Engine - Community
[2021-03-25T09:36:55.495Z]  Engine:
[2021-03-25T09:36:55.495Z]   Version:          20.10.3
[2021-03-25T09:36:55.495Z]   API version:      1.41 (minimum version 1.12)
[2021-03-25T09:36:55.495Z]   Go version:       go1.13.15
[2021-03-25T09:36:55.495Z]   Git commit:       46229ca
[2021-03-25T09:36:55.495Z]   Built:            Fri Jan 29 14:31:25 2021
[2021-03-25T09:36:55.495Z]   OS/Arch:          linux/amd64
[2021-03-25T09:36:55.495Z]   Experimental:     false
[2021-03-25T09:36:55.495Z]  containerd:
[2021-03-25T09:36:55.495Z]   Version:          1.4.4
[2021-03-25T09:36:55.495Z]   GitCommit:        05f951a3781f4f2c1911b05e61c160e9c30eaa8e
[2021-03-25T09:36:55.495Z]  runc:
[2021-03-25T09:36:55.495Z]   Version:          1.0.0-rc93
[2021-03-25T09:36:55.495Z]   GitCommit:        12644e614e25b05da6fd08a38ffa0cfe1903fdec
[2021-03-25T09:36:55.495Z]  docker-init:
[2021-03-25T09:36:55.495Z]   Version:          0.19.0
[2021-03-25T09:36:55.495Z]   GitCommit:        de40ad0
[2021-03-25T09:36:55.495Z] Change ownership of all files inside the specific folder from root/root to current user/group
[2021-03-25T09:36:57.439Z] Change permissions with write access of all files inside the specific folder
[2021-03-25T09:36:58.402Z] Running in /var/lib/jenkins/workspace/PR-24626-10-2473d663-2d32-4db7-95e9-60c9ba43dfdd/src/github.com/elastic/beats/build
[2021-03-25T09:36:58.709Z] + rm -rf ve
[2021-03-25T09:36:58.709Z] + find . -type d -name vendor -exec rm -r {} ;
[2021-03-25T09:36:59.038Z] + python .ci/scripts/pre_archive_test.py
[2021-03-25T09:36:59.038Z] Copy ./x-pack/packetbeat/build into build/x-pack/packetbeat/build
[2021-03-25T09:36:59.058Z] Running in /var/lib/jenkins/workspace/PR-24626-10-2473d663-2d32-4db7-95e9-60c9ba43dfdd/src/github.com/elastic/beats/build
[2021-03-25T09:36:59.082Z] Recording test results
[2021-03-25T09:37:02.011Z] None of the test reports contained any result
[2021-03-25T09:37:02.019Z] [Checks API] No suitable checks publisher found.
[2021-03-25T09:37:02.377Z] + go clean -modcache
[2021-03-25T09:37:06.010Z] Cleaning up /var/lib/jenkins/workspace/PR-24626-10-2473d663-2d32-4db7-95e9-60c9ba43dfdd
[2021-03-25T09:37:06.011Z] Client: Docker Engine - Community
[2021-03-25T09:37:06.011Z]  Version:           20.10.3
[2021-03-25T09:37:06.011Z]  API version:       1.41
[2021-03-25T09:37:06.011Z]  Go version:        go1.13.15
[2021-03-25T09:37:06.011Z]  Git commit:        48d30b5
[2021-03-25T09:37:06.011Z]  Built:             Fri Jan 29 14:33:13 2021
[2021-03-25T09:37:06.011Z]  OS/Arch:           linux/amd64
[2021-03-25T09:37:06.011Z]  Context:           default
[2021-03-25T09:37:06.011Z]  Experimental:      true
[2021-03-25T09:37:06.011Z] 
[2021-03-25T09:37:06.011Z] Server: Docker Engine - Community
[2021-03-25T09:37:06.011Z]  Engine:
[2021-03-25T09:37:06.011Z]   Version:          20.10.3
[2021-03-25T09:37:06.011Z]   API version:      1.41 (minimum version 1.12)
[2021-03-25T09:37:06.011Z]   Go version:       go1.13.15
[2021-03-25T09:37:06.011Z]   Git commit:       46229ca
[2021-03-25T09:37:06.011Z]   Built:            Fri Jan 29 14:31:25 2021
[2021-03-25T09:37:06.011Z]   OS/Arch:          linux/amd64
[2021-03-25T09:37:06.011Z]   Experimental:     false
[2021-03-25T09:37:06.011Z]  containerd:
[2021-03-25T09:37:06.011Z]   Version:          1.4.4
[2021-03-25T09:37:06.011Z]   GitCommit:        05f951a3781f4f2c1911b05e61c160e9c30eaa8e
[2021-03-25T09:37:06.011Z]  runc:
[2021-03-25T09:37:06.011Z]   Version:          1.0.0-rc93
[2021-03-25T09:37:06.011Z]   GitCommit:        12644e614e25b05da6fd08a38ffa0cfe1903fdec
[2021-03-25T09:37:06.011Z]  docker-init:
[2021-03-25T09:37:06.011Z]   Version:          0.19.0
[2021-03-25T09:37:06.011Z]   GitCommit:        de40ad0
[2021-03-25T09:37:06.011Z] Change ownership of all files inside the specific folder from root/root to current user/group
[2021-03-25T09:37:06.953Z] Change permissions with write access of all files inside the specific folder
[2021-03-25T09:37:07.561Z] Running in /var/lib/jenkins/workspace/PR-24626-10-2473d663-2d32-4db7-95e9-60c9ba43dfdd
[2021-03-25T11:20:23.869Z] Cancelling nested steps due to timeout
[2021-03-25T11:20:23.889Z] Failed in branch x-pack/functionbeat-windows-2012-windows-2012-r2
[2021-03-25T11:20:24.064Z] Stage "Packaging" skipped due to earlier failure(s)
[2021-03-25T11:20:24.146Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-24626/src/github.com/elastic/beats
[2021-03-25T11:20:24.609Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-24626
[2021-03-25T11:20:24.676Z] [INFO] getVaultSecret: Getting secrets
[2021-03-25T11:20:24.776Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-03-25T11:20:25.583Z] + chmod 755 generate-build-data.sh
[2021-03-25T11:20:25.583Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-24626/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-24626/runs/10 ABORTED 10916938
[2021-03-25T11:20:25.834Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-24626/runs/10/steps/?limit=10000 -o steps-info.json
[2021-03-25T11:20:32.412Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-24626/runs/10/tests/?status=FAILED -o tests-errors.json

@narph
Copy link
Contributor Author

narph commented Mar 23, 2021

/test

2 similar comments
@kuisathaverat
Copy link
Contributor

/test

@narph
Copy link
Contributor Author

narph commented Mar 24, 2021

/test

@kuisathaverat
Copy link
Contributor

I have relaunched e2e test only is the only thing is failing now

@kuisathaverat
Copy link
Contributor

the build https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-24626/9/pipeline is green no changes since that build, the latest only do not run Build&Test / x-pack/functionbeat-windows-2012-windows-2012-r2 stage everything else is fine. I think is fine to merge it.

@narph narph merged commit 34e528a into elastic:7.x Mar 26, 2021
@narph narph deleted the backport_24502_7.x branch March 26, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants