Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to set shipper name (cherry-pick into 5.0) #2410

Merged
merged 3 commits into from
Aug 31, 2016

Conversation

dedemorton
Copy link
Contributor

No description provided.

@@ -26,7 +26,7 @@ Contains common beat fields available in all event types.
[float]
=== beat.name

The name of the Beat sending the log messages. If the shipper name is set in the configuration file, then that value is used. If it is not set, the hostname is used.
The name of the Beat sending the log messages. If the shipper name is set in the configuration file, then that value is used. If it is not set, the hostname is used. To set the shipper name, use the `name` option in the configuration file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always refer here to shipper name but in the config and here it is only beat.name or name. Not sure if this could be confusing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruflin Drats, I think you're right. I meant shipper name to be descriptive, but saying Beat name is probably less confusing.

@ruflin ruflin merged commit 4b49164 into elastic:5.0 Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants