Fix/windows case sensitivity #22653
Closed
Fix/windows case sensitivity #22653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fix an issue when trying to uninstall the Elastic Agent on Windows by using a path that doesn't match the system case sensitivity. This make sure the following are considered to be the same. - C:/path-to-agent/elastic-agent uninstall - c:/path-to-agent/elastic-agent uninstall Fixes: #22268
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
reviewed
Nov 20, 2020
| @@ -58,6 +60,15 @@ func RunningInstalled() bool { | |||
| execDir = filepath.Dir(filepath.Dir(execDir)) | |||
| execPath = filepath.Join(execDir, execName) | |||
| } | |||
|
|
|||
| // Windows filesystem is case insensitive and the following paths are the same. | |||
| // - C:\TMP | |||
There was a problem hiding this comment.
maybe we can extract this to paths package and compare paths using paths.AreEqual or something similar
|
@blakerouse I just tested the workflow referenced in the issue, nothing else I can do a bit more of testing. |
Since this at least fixes the user-reported bug #22268, can we merge it for now and open another issue later if other bugs come up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix uninstall problem on windows with case sensitivity
This PR fix an issue when trying to uninstall the Elastic Agent on
Windows by using a path that doesn't match the system case sensitivity.
This make sure the following are considered to be the same.
Fixes: #22268
What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs