Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more problems found during testing #22579

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Fix more problems found during testing #22579

merged 3 commits into from
Nov 17, 2020

Conversation

dedemorton
Copy link
Contributor

No description provided.

@dedemorton dedemorton requested a review from ph November 13, 2020 03:35
@dedemorton dedemorton self-assigned this Nov 13, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management labels Nov 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 13, 2020
@elasticmachine
Copy link
Collaborator

❕ Flaky test report

No test was executed to be analysed.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 13, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Victor Martinez]

  • Start Time: 2020-11-17T09:17:53.095+0000

  • Duration: 27 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 1402
Skipped 4
Total 1406

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1402
Skipped 4
Total 1406

@andresrc andresrc requested a review from blakerouse November 14, 2020 07:43
ph
ph approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment concerning macOS, but everything LGTM

@dedemorton dedemorton requested a review from a team as a code owner November 17, 2020 04:42
@dedemorton dedemorton merged commit 50a76b1 into elastic:master Nov 17, 2020
@dedemorton dedemorton deleted the testing_fixes branch November 17, 2020 20:37
This was referenced Nov 17, 2020
Merged
Merged
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 17, 2020
@dedemorton
Fix more problems found during testing (elastic#22579)
a21fa11 
* Fix more problems found during testing

* Add fixes from review

* Run make update
@dedemorton dedemorton mentioned this pull request Nov 17, 2020
Closed
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 17, 2020
@dedemorton
Fix more problems found during testing (elastic#22579)
1a8463b 
* Fix more problems found during testing

* Add fixes from review

* Run make update
dedemorton added a commit that referenced this pull request Nov 18, 2020
@dedemorton
Fix more problems found during testing (#22579) (#22636)
61034e8 
* Fix more problems found during testing

* Add fixes from review

* Run make update
dedemorton added a commit that referenced this pull request Nov 18, 2020
@dedemorton
Fix more problems found during testing (#22579) (#22635)
b65d67f 
* Fix more problems found during testing

* Add fixes from review

* Run make update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse

Assignees

@dedemorton dedemorton

Labels
docs v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dedemorton @elasticmachine @ph