Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22228 to 7.x: [Filebeat] Rename awscloudwatch input to aws-cloudwatch input #22524

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Cherry-pick #22228 to 7.x: [Filebeat] Rename awscloudwatch input to aws-cloudwatch input #22524

merged 1 commit into from
Nov 11, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Nov 10, 2020

Cherry-pick of PR #22228 to 7.x branch. Original message:

What does this PR do?

This PR is to rename awscloudwatch input to aws-cloudwatch to follow the naming convention for Filebeat inputs.
After this PR get cherry-picked into 7.x, we can remove support of awscloudwatch. Or create a separate issue to remove old names in 8.0.

Deprecation warning log message is also added to this PR:

2020-10-28T12:41:21.556-0600    WARN    [aws-cloudwatch]        awscloudwatch/input.go:93       awscloudwatch input name is deprecated, please use aws-cloudwatch instead

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Make sure both awscloudwatch and aws-cloudwatch input work:

filebeat.inputs:
  - type: awscloudwatch
    credential_profile_name: elastic-beats
    log_group_arn: arn:aws:logs:us-east-1:428152502467:log-group:test:*
    region: us-east-1
    scan_frequency: 30s
    start_position: beginning
    api_timeout: 5m

and

filebeat.inputs:
  - type: aws-cloudwatch
    credential_profile_name: elastic-beats
    log_group_arn: arn:aws:logs:us-east-1:428152502467:log-group:test:*
    region: us-east-1
    scan_frequency: 30s
    start_position: beginning
    api_timeout: 5m

Related issues

* Rename awscloudwatch input to aws-cloudwatch input

* add deprecation warning message

(cherry picked from commit 28ad00b)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Nov 10, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 10, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Nov 10, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4472
Skipped 567
Total 5039

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22524 opened]

  • Start Time: 2020-11-10T17:27:15.702+0000

  • Duration: 48 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 4472
Skipped 567
Total 5039

@kaiyan-sheng kaiyan-sheng merged commit d242a6d into elastic:7.x Nov 11, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_22228_7.x branch November 11, 2020 22:17
@zube zube bot removed the [zube]: Done label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants