Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22126 to 7.x: [filebeat][httpjson] Use default config when creating the input #22139

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 26, 2020

Cherry-pick of PR #22126 to 7.x branch. Original message:

What does this PR do?

Use default config when creating the input.

Why is it important?

Some config could fail if some required field is not set but has a default value.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 26, 2020
@marc-gr marc-gr requested a review from a team October 26, 2020 09:21
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22139 opened]

  • Start Time: 2020-10-26T09:19:56.561+0000

  • Duration: 71 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

@marc-gr marc-gr merged commit af00eaf into elastic:7.x Oct 26, 2020
@marc-gr marc-gr deleted the backport_22126_7.x branch October 26, 2020 16:43
@zube zube bot removed the [zube]: Done label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants