Cherry-pick #21931 to 7.x: [Elastic Agent] Fix named pipe communication on Windows 7 #21977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Fix named pipes on Windows 7. * Add changelog fix notice. (cherry picked from commit 803ddca)
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
michalpristas
approved these changes
Oct 20, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21931 to 7.x branch. Original message:
What does this PR do?
Fixes issue where on Windows 7 the first connection over a npipe would result in the client hanging and the server from never receiving the connection.
After digging deep into the Windows winio module I was able to determine it was an issue in the module and not in the Agent itself. microsoft/go-winio#173 Was reported as the issue, but has not been fixed in winio upstream. Use replace to github.com/bi-zone/go-winio fixes the issue as the change is committed in that repository and tagged.
Why is it important?
So installation of Elastic Agent works as expected and actions talking to the running daemon do not hang and block the executing installation.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues