Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][flaky] reporting for PRs in GitHub #21853

Merged
merged 24 commits into from
Oct 27, 2020
Merged

[CI][flaky] reporting for PRs in GitHub #21853

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9e989aa
[CI][flaky] reporting
v1v Oct 15, 2020
446299b
Use the right indice
v1v Oct 15, 2020
970eafc
Fix missing comma
v1v Oct 15, 2020
4039f89
Merge remote-tracking branch 'upstream/master' into feature/support-f…
v1v Oct 19, 2020
c6957e6
Force test failure in an existing flaky test
v1v Oct 22, 2020
ba9957b
Add debug logs
v1v Oct 22, 2020
6e6e094
chore: for testing purposes
v1v Oct 22, 2020
3a701bd
Force flaky failures for filebeat and libbeat
v1v Oct 22, 2020
6c01d3e
Merge branch 'master' into feature/support-flaky-test-analyser
v1v Oct 26, 2020
2ec9d4a
chore: for testing purposes
v1v Oct 26, 2020
290ff18
Merge branch 'feature/support-flaky-test-analyser' of github.com:v1v/…
v1v Oct 26, 2020
32b57a2
Merge branch 'master' into feature/support-flaky-test-analyser
v1v Oct 26, 2020
5532351
chore: for testing purposes
v1v Oct 26, 2020
2b69e3e
Merge branch 'feature/support-flaky-test-analyser' of github.com:v1v/…
v1v Oct 26, 2020
f45b272
Use the workspace where to run the notifyBuildResult
v1v Oct 26, 2020
7753860
Revert "chore: for testing purposes"
v1v Oct 27, 2020
35a3b64
Revert "chore: for testing purposes"
v1v Oct 27, 2020
f6a441d
Revert "Force flaky failures for filebeat and libbeat"
v1v Oct 27, 2020
0faff8a
Revert "chore: for testing purposes"
v1v Oct 27, 2020
e3bc132
Revert "Add debug logs"
v1v Oct 27, 2020
df4057f
Revert "Force test failure in an existing flaky test"
v1v Oct 27, 2020
9c3d147
Merge remote-tracking branch 'upstream/master' into feature/support-f…
v1v Oct 27, 2020
0757395
Merge remote-tracking branch 'upstream/master' into feature/support-f…
v1v Oct 27, 2020
a0243f8
Merge branch 'feature/support-flaky-test-analyser' of github.com:v1v/…
v1v Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ pipeline {
runbld(stashedTestReports: stashedTestReports, project: env.REPO)
}
cleanup {
notifyBuildResult(prComment: true, slackComment: true, slackNotify: (isBranch() || isTag()))
notifyBuildResult(prComment: true,
slackComment: true, slackNotify: (isBranch() || isTag())
analyzeFlakey: true, flakyReportIdx: "reporter-beats-pipeline-master")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we should use as many indices as release branches we got and use the CHANGE_TARGET for the PRs or BRANCH_NAME for the branches/tags.

But, anytime there is a new release, then we might need to create a new indice.

@cachedout , what are your thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is an issue we need to figure out. I think that the thing to do here is to use one index per project and then include a field that we can filter against when searching for documents, but to achieve that I think we need to make some changes to the way we actually generate the flaky test analysis.

For now, I propose that we keep it as-is and address this in the test analyzer itself. Then we can come back and change the pipelines as-needed.

}
}
}
Expand Down