Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21540 to 7.x: Add support for additional fields from V2 ALB logs #21579

Merged
merged 7 commits into from
Oct 8, 2020
Merged

Cherry-pick #21540 to 7.x: Add support for additional fields from V2 ALB logs #21579

merged 7 commits into from
Oct 8, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 6, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21540 to 7.x branch. Original message:

What does this PR do?

This PR is to add support for additional 4 fields from V2 ALB logs.

  • "target:port_list"
  • "target_status_code_list"
  • "classification"
  • "classification_reason"

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@kaiyan-sheng
Add support for additional fields from V2 ALB logs (#21540)
36daabc 
* Add support for additional fields from V2 ALB logs

* Add new fields as optional fields and regenerate -expected.json files

* add changelog

(cherry picked from commit a2decea)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 6, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 6, 2020
narph
narph approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 6, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21579 updated]

  • Start Time: 2020-10-07T20:28:05.655+0000

  • Duration: 71 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 4414
Skipped 570
Total 4984

@jsoriano
Copy link
Member

jsoriano commented Oct 7, 2020

Related to the failures in filebeat builds: #21526

@kaiyan-sheng
Copy link
Contributor Author

@jsoriano Thank you!! Github for some reason won't let me create my PR to regenerate all the -expected.json 😂

@kaiyan-sheng kaiyan-sheng merged commit d6d7c85 into elastic:7.x Oct 8, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_21540_7.x branch October 8, 2020 01:34
@zube zube bot removed the [zube]: Done label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narph narph narph approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @jsoriano @narph