Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21488 to 7.x: Download asc from artifact store specified in spec #21523

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Cherry-pick #21488 to 7.x: Download asc from artifact store specified in spec #21523

merged 1 commit into from
Oct 5, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #21488 to 7.x branch. Original message:

What does this PR do?

For asc atrifact name was hardcoded to beats, which caused issues with endpoint

Why is it important?

So endpoint can be securely downloaded.
Fixes: #21485

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas
[Ingest Manager] Download asc from artifact store specified in spec (e…
6ce3b27 
…lastic#21488)

[Ingest Manager] Download asc from artifact store specified in spec (elastic#21488)
@michalpristas michalpristas added bug Team:Ingest Management Ingest Management:beta2 Group issues for ingest management beta2 labels Oct 5, 2020
@michalpristas michalpristas self-assigned this Oct 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 5, 2020
blakerouse
blakerouse approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 5, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21523 opened, Started by user Michal Pristas, Rebuilds build #1]

  • Start Time: 2020-10-05T15:03:34.054+0000

  • Duration: 36 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 4
Total 1388

@michalpristas michalpristas merged commit 0b22a3c into elastic:7.x Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
bug Ingest Management:beta2 Group issues for ingest management beta2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @blakerouse