Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21486 to 7.x: Ignore unsupported metrics in the azure module #21513

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Cherry-pick #21486 to 7.x: Ignore unsupported metrics in the azure module #21513

merged 2 commits into from
Oct 5, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Oct 5, 2020

Cherry-pick of PR #21486 to 7.x branch. Original message:

What does this PR do?

Expands the ignore_unsupported configure option to metrics as well.

Why is it important?

Azure Monitor seems to have removed some of the supported metrics in compute_vm_scaleset. due to the fact that they have been hardcoded inside the manifest file it will throw an error. This option will make sure the sudden unsupported metrics are ignored.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
Ignore unsupported metrics in the azure module (elastic#21486)
c235cf7 
* mofidy doc

* add ignore

* changelog

(cherry picked from commit 7716397)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 5, 2020
@narph narph self-assigned this Oct 5, 2020
@narph narph added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 5, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 5, 2020 •
edited by jenkins-beats-ci bot
Loading

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21513 opened]

  • Reason: Aborted from #2

  • Start Time: 2020-10-05T10:08:36.776+0000

  • Duration: 70 min 13 sec

  • Commit: c235cf7

Test stats 🧪

Test Results
Failed 0
Passed 617
Skipped 48
Total 665

Log output

Expand to view the last 100 lines of log output 

[2020-10-05T11:16:32.112Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 2m30s elapsed]
[2020-10-05T11:16:42.126Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 2m40s elapsed]
[2020-10-05T11:16:52.133Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 2m50s elapsed]
[2020-10-05T11:17:02.144Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 3m0s elapsed]
[2020-10-05T11:17:12.157Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 3m10s elapsed]
[2020-10-05T11:17:22.224Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 3m20s elapsed]
[2020-10-05T11:17:32.248Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 3m30s elapsed]
[2020-10-05T11:17:42.271Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 3m40s elapsed]
[2020-10-05T11:17:52.282Z] aws_db_instance.test: Still destroying... [id=metricbeat-test-a180b8b1, 3m50s elapsed]
[2020-10-05T11:17:53.228Z] aws_db_instance.test: Destruction complete after 3m51s
[2020-10-05T11:17:53.228Z] random_id.suffix: Destroying... [id=oYC4sQ]
[2020-10-05T11:17:53.228Z] random_password.db: Destroying... [id=none]
[2020-10-05T11:17:53.228Z] random_password.db: Destruction complete after 0s
[2020-10-05T11:17:53.228Z] random_id.suffix: Destruction complete after 0s
[2020-10-05T11:17:53.228Z] 
[2020-10-05T11:17:53.228Z] Destroy complete! Resources: 7 destroyed.
[2020-10-05T11:17:53.228Z] + cd -
[2020-10-05T11:17:53.228Z] /var/lib/jenkins/workspace/Beats_beats_PR-21513/src/github.com/elastic/beats/src/github.com/elastic/beats
[2020-10-05T11:17:53.228Z] + exit 0
[2020-10-05T11:17:53.639Z] Client: Docker Engine - Community
[2020-10-05T11:17:53.639Z]  Version:           19.03.13
[2020-10-05T11:17:53.639Z]  API version:       1.40
[2020-10-05T11:17:53.639Z]  Go version:        go1.13.15
[2020-10-05T11:17:53.639Z]  Git commit:        4484c46d9d
[2020-10-05T11:17:53.639Z]  Built:             Wed Sep 16 17:02:36 2020
[2020-10-05T11:17:53.639Z]  OS/Arch:           linux/amd64
[2020-10-05T11:17:53.639Z]  Experimental:      false
[2020-10-05T11:17:53.639Z] 
[2020-10-05T11:17:53.639Z] Server: Docker Engine - Community
[2020-10-05T11:17:53.639Z]  Engine:
[2020-10-05T11:17:53.639Z]   Version:          19.03.13
[2020-10-05T11:17:53.639Z]   API version:      1.40 (minimum version 1.12)
[2020-10-05T11:17:53.639Z]   Go version:       go1.13.15
[2020-10-05T11:17:53.639Z]   Git commit:       4484c46d9d
[2020-10-05T11:17:53.639Z]   Built:            Wed Sep 16 17:01:06 2020
[2020-10-05T11:17:53.639Z]   OS/Arch:          linux/amd64
[2020-10-05T11:17:53.640Z]   Experimental:     false
[2020-10-05T11:17:53.640Z]  containerd:
[2020-10-05T11:17:53.640Z]   Version:          1.3.7
[2020-10-05T11:17:53.640Z]   GitCommit:        8fba4e9a7d01810a393d5d25a3621dc101981175
[2020-10-05T11:17:53.640Z]  runc:
[2020-10-05T11:17:53.640Z]   Version:          1.0.0-rc10
[2020-10-05T11:17:53.640Z]   GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
[2020-10-05T11:17:53.640Z]  docker-init:
[2020-10-05T11:17:53.640Z]   Version:          0.18.0
[2020-10-05T11:17:53.640Z]   GitCommit:        fec3683
[2020-10-05T11:18:01.666Z] [INFO] unstashV2: JOB_GCS_BUCKET is set. bucket param got precedency instead.
[2020-10-05T11:18:01.693Z] [INFO] unstashV2: JOB_GCS_CREDENTIALS is set. credentialsId param got precedency instead.
[2020-10-05T11:18:01.777Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs://beats-ci-temp/Beats/beats/PR-21513-1/source/source.tgz
[2020-10-05T11:18:01.806Z] [Google Cloud Storage Plugin] Downloading: Beats/beats/PR-21513-1/source/source.tgz to local path: /var/lib/jenkins/workspace/Beats_beats_PR-21513/source.tgz
[2020-10-05T11:18:14.906Z] + tar --version
[2020-10-05T11:18:15.227Z] + tar -xpf source.tgz
[2020-10-05T11:18:27.836Z] + rm source.tgz
[2020-10-05T11:18:27.935Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21513/src/github.com/elastic/beats
[2020-10-05T11:18:27.968Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21513/src/github.com/elastic/beats/uncategorized-1601893900069
[2020-10-05T11:18:28.074Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21513/src/github.com/elastic/beats/x-pack-metricbeat-windows-windows-2019-1601895322246
[2020-10-05T11:18:28.181Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21513/src/github.com/elastic/beats/x-pack-metricbeat-build-1601896377679
[2020-10-05T11:18:28.613Z] + cat
[2020-10-05T11:18:28.613Z] + /usr/local/bin/runbld ./runbld-test-reports --job-name elastic+beats+pull-request
[2020-10-05T11:18:28.613Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-10-05T11:18:35.254Z] runbld>>> runbld started
[2020-10-05T11:18:35.254Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-10-05T11:18:37.176Z] runbld>>> The following profiles matched the job 'elastic+beats+pull-request' in order of occurrence in the config (last value wins).
[2020-10-05T11:18:37.176Z] runbld>>> Matches in the system config:
[2020-10-05T11:18:37.176Z] runbld>>> - Matched ^elastic\+beats
[2020-10-05T11:18:37.176Z] runbld>>> - Matched ^elastic\+beats\+pull-request
[2020-10-05T11:18:38.565Z] runbld>>> Debug logging enabled.
[2020-10-05T11:18:38.565Z] runbld>>> Storing result
[2020-10-05T11:18:38.829Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-10-05T11:18:38.829Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201005111838-73562433
[2020-10-05T11:18:38.829Z] runbld>>> Adding system facts.
[2020-10-05T11:18:40.230Z] runbld>>> Adding vcs info for the latest commit:  c235cf7c5cccb8010e7ae86e664d86250ebc7a7e
[2020-10-05T11:18:40.230Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-10-05T11:18:40.230Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-10-05T11:18:40.230Z] + echo 'Processing JUnit reports with runbld...'
[2020-10-05T11:18:40.230Z] Processing JUnit reports with runbld...
[2020-10-05T11:18:40.491Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-10-05T11:18:40.491Z] runbld>>> DURATION: 24ms
[2020-10-05T11:18:40.491Z] runbld>>> STDOUT: 40 bytes
[2020-10-05T11:18:40.491Z] runbld>>> STDERR: 49 bytes
[2020-10-05T11:18:40.491Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-10-05T11:18:40.491Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-21513
[2020-10-05T11:18:41.438Z] runbld>>> Storing build metadata: 
[2020-10-05T11:18:41.438Z] runbld>>> Adding test report.
[2020-10-05T11:18:41.438Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-21513/src/github.com/elastic/beats
[2020-10-05T11:18:42.386Z] runbld>>> Found 6 test output files
[2020-10-05T11:18:42.651Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 665 Skipped: 44
[2020-10-05T11:18:42.651Z] runbld>>> Storing result
[2020-10-05T11:18:42.651Z] runbld>>> FAILURES: 0
[2020-10-05T11:18:42.915Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-10-05T11:18:42.915Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201005111838-73562433
[2020-10-05T11:18:43.180Z] runbld>>> Email notification disabled by environment variable.
[2020-10-05T11:18:43.180Z] runbld>>> Slack notification disabled by environment variable.
[2020-10-05T11:18:49.101Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-21513
[2020-10-05T11:18:49.214Z] [INFO] getVaultSecret: Getting secrets
[2020-10-05T11:18:49.310Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-10-05T11:18:50.246Z] + chmod 755 generate-build-data.sh
[2020-10-05T11:18:50.246Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21513/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21513/runs/1 ABORTED 4213190
[2020-10-05T11:18:50.246Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21513/runs/1/steps/?limit=10000 -o steps-info.json
[2020-10-05T11:18:50.797Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21513/runs/1/tests/?status=FAILED -o tests-errors.json

@narph narph merged commit 9bd21a5 into elastic:7.x Oct 5, 2020
@narph narph deleted the backport_21486_7.x branch October 5, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @ChrsMark