Cherry-pick #21380 to 7.9: [filebeat] Fix shutdown tracking in s3 input #21397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d8d35a1)
|
Pinging @elastic/integrations (Team:Integrations) |
kaiyan-sheng
approved these changes
Sep 29, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit 7f5ccd3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21380 to 7.9 branch. Original message:
This is just a short fix -- the s3 input's wait group (used to wait for shutdown) currently calls
wg.Done()immediately after the (asynchronous) call site, so thewg.Wait()on shutdown is always a no-op. This PR moves thewg.Done()call to the end of the worker goroutine, which is probably what was intended.