Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Fix tests for Heartbeat config #20742

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

andrewkroh
Copy link
Member

What does this PR do?

Fixes a broken test in Elastic Agent. The tests expected dataset rather than data_stream.

The tests expected dataset rather than data_stream.
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management labels Aug 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 22, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20742 opened]

  • Start Time: 2020-08-22T12:53:42.585+0000

  • Duration: 34 min 33 sec

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh merged commit 03b2c14 into elastic:master Aug 23, 2020
@ruflin
Copy link
Contributor

ruflin commented Aug 24, 2020

@andrewkroh Thanks for the fix. @michalpristas @blakerouse Could you follow up here if we need backports?

@michalpristas
Copy link
Contributor

7.x backported correctly here: #20387
heartbeat change not part of 7.9 no backport needed

melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
The tests expected dataset rather than data_stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants