Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Fix tests for synthetics using data_stream. #20498

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Fixes the added synthetics unit tests that didn't update from dataset to data_steam.

Why is it important?

So all unit tests pass.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 7, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20498 opened]

  • Start Time: 2020-08-07T12:46:54.085+0000

  • Duration: 34 min 57 sec

@ruflin
Copy link
Contributor

ruflin commented Aug 12, 2020

jenkins, test this

@andrewvc
Copy link
Contributor

jenkins, test this

@ph
Copy link
Contributor

ph commented Aug 17, 2020

Jenkins, test this

@blakerouse blakerouse closed this Aug 25, 2020
@blakerouse blakerouse force-pushed the agent-synthetics-datastream-test-fix branch from 7c7f465 to 03748b3 Compare August 25, 2020 15:44
@blakerouse blakerouse deleted the agent-synthetics-datastream-test-fix branch August 25, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants