Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20406 to 7.x: Makes metrics config option required in app_insights #20423

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Cherry-pick #20406 to 7.x: Makes metrics config option required in app_insights #20423

merged 1 commit into from
Aug 4, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 4, 2020 •
edited
Loading

Cherry-pick of PR #20406 to 7.x branch. Original message:

What does this PR do?

Makes metrics config option required.

Why is it important?

Validation

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
Makes metrics config option required in app_insights (elastic#20406)
befaf69 
* mofidy doc

* config

* changelog

* generate

* regen

* mage fmt

(cherry picked from commit 496e3c9)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 4, 2020
@narph narph changed the title Cherry-pick #20406 to 7.9: Makes metrics config option required in app_insights Cherry-pick #20406 to 7.x: Makes metrics config option required in app_insights Aug 4, 2020
@narph narph self-assigned this Aug 4, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Aug 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 4, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20423 opened]

  • Start Time: 2020-08-04T12:03:04.540+0000

  • Duration: 61 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 3506
Skipped 797
Total 4303

@narph narph merged commit eb914d5 into elastic:7.x Aug 4, 2020
@narph narph deleted the backport_20406_7.x branch August 4, 2020 13:54
@zube zube bot removed the [zube]: Done label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @kaiyan-sheng