-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cost warning to aws, googlecloud and azure doc #20033
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one minor comment.
I'll mark as approved and you can decide how to proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -18,6 +18,9 @@ Additional azure API calls will be executed in order to retrieve information reg | |||
|
|||
The azure module mericsets are `monitor`, `compute_vm` and `compute_vm_scaleset` | |||
|
|||
IMPORTANT: Extra Azure charges on metric queries may be generated by this module. | |||
Please see <<<<azure-api-cost,additional notes about metrics and costs>> for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaiyan-sheng I think you have a typo here with the extra <<
chars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch! I will fix it in a new PR! Thanks!!
* Add cost warning to aws googlecloud and azure doc
…lastic#20120) * Add cost warning to aws googlecloud and azure doc (cherry picked from commit 62b390f)
This PR is to add
WARNING
message in public cloud module documentations about potential cost may be introduced by API calls.This PR is to add documentation change of #19940.