Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cost warning to aws, googlecloud and azure doc #20033

Merged
merged 7 commits into from
Jul 21, 2020
Merged

Add cost warning to aws, googlecloud and azure doc #20033

merged 7 commits into from
Jul 21, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 17, 2020

This PR is to add WARNING message in public cloud module documentations about potential cost may be introduced by API calls.

Screen Shot 2020-07-17 at 10 18 35 AM

This PR is to add documentation change of #19940.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 17, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 17, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Jul 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 17, 2020
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment.

I'll mark as approved and you can decide how to proceed.

metricbeat/docs/modules/aws.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 20, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20033 updated]

  • Start Time: 2020-07-21T19:58:20.036+0000

  • Duration: 22 min 16 sec

metricbeat/docs/modules/aws.asciidoc Show resolved Hide resolved
metricbeat/docs/modules/azure.asciidoc Outdated Show resolved Hide resolved
metricbeat/docs/modules/googlecloud.asciidoc Outdated Show resolved Hide resolved
x-pack/metricbeat/module/azure/_meta/docs.asciidoc Outdated Show resolved Hide resolved
x-pack/metricbeat/module/googlecloud/_meta/docs.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -18,6 +18,9 @@ Additional azure API calls will be executed in order to retrieve information reg

The azure module mericsets are `monitor`, `compute_vm` and `compute_vm_scaleset`

IMPORTANT: Extra Azure charges on metric queries may be generated by this module.
Please see <<<<azure-api-cost,additional notes about metrics and costs>> for more details.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaiyan-sheng I think you have a typo here with the extra << chars

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch! I will fix it in a new PR! Thanks!!

kaiyan-sheng added a commit that referenced this pull request Jul 22, 2020
* Add cost warning to aws googlecloud and azure doc

(cherry picked from commit e5d0373)
kaiyan-sheng added a commit that referenced this pull request Jul 22, 2020
* Add cost warning to aws googlecloud and azure doc

(cherry picked from commit e5d0373)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
* Add cost warning to aws googlecloud and azure doc
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#20120)

* Add cost warning to aws googlecloud and azure doc

(cherry picked from commit 62b390f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team v7.9.0 v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants