-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #19329 to 7.x: [Filebeat][GSuite] Initial implementation of SAML and User Accounts filesets #19726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 8, 2020
Collaborator
andrewkroh
reviewed
Jul 13, 2020
@@ -66,6 +66,10 @@ field. You can revert this change by configuring tags for the module and omittin | |||
- Adds check on `<no value>` config option value for the azure input `resource_manager_endpoint`. {pull}18890[18890] | |||
- Okta module now requires objects instead of JSON strings for the `http_headers`, `http_request_body`, `pagination`, `rate_limit`, and `ssl` variables. {pull}18953[18953] | |||
- Adds oauth support for httpjson input. {issue}18415[18415] {pull}18892[18892] | |||
- Adds `split_events_by` option to httpjson input. {pull}19246[19246] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks it it picked up two extra lines.
marc-gr
force-pushed
the
backport_19329_7.x
branch
from
July 14, 2020 21:57
893620e
to
32e94ee
Compare
This has some test failures: https://beats-ci.elastic.co/job/Beats/job/beats/job/PR-19726/2/testReport/ |
#19925 needs to get merged first |
…ilesets (elastic#19329) * GSuite initial implementation of SAML fileset * Document fields and generate test file * Add documentation * Split fields and improve docs * Add change to CHANGELOG * Rename config file and clean docs * Adds user accounts fileset * Add delegated user to google oauth * Add types and make changes to common pipeline * Do not stop input if array key not found * Fix docs * Setup for date cursor * Add beta tag * CHANGELOG message * Improve ECS mappings * Change cateogrization and types of various fields * Change event.type to start * Improve doc references (cherry picked from commit 7abd67d)
marc-gr
force-pushed
the
backport_19329_7.x
branch
from
July 14, 2020 23:03
32e94ee
to
bc8cd34
Compare
andrewkroh
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19329 to 7.x branch. Original message:
What does this PR do?
This PR adds a GSuite module to filebeat that uses
httpjson
as input, and creates a SAML and User accounts filesets for it, which consumes events from https://developers.google.com/admin-sdk/reports/v1/appendix/activity/[saml|user-accounts]Why is it important?
It is the first step to allow users to consume
gsuite
activity reports. It sets the common pieces for the next filesets and since SAML and User accounts are the simplest ones makes it easy to test and validate the module functionality.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
Depends on
#19246