-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetricBeat] support wildcard *
dimension value in AWS CloudWatch module
#19660
[MetricBeat] support wildcard *
dimension value in AWS CloudWatch module
#19660
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works! Just one nit about adding a unit test for configDimensionValueContainsWildcard function. Thank you for the contribution!!
jenkins run tests please |
Ok, I will add that unit test, thank you |
jenkins run the tests |
jenkins run the tests |
@kwinstonix Thank you! I just resolved the merge conflict and once the CI gives a green, I will merge this PR and backport it. Thanks again for your contribution!! |
…odule (elastic#19660) * dimension value could be wildcard `*`, it is more flexible
What does this PR do?
*
dimension value in AWS CloudWatch metrics configWhy is it important?
Now we must set explicit dimension value to filter out CloudWatch metrics. It will be flexible if we can support wildcard
*
in value param.current config example:
with the enhancement:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues