Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated santa module to use new nullcheck in set processors #19417

Merged
merged 1 commit into from
Jul 14, 2020
Merged

updated santa module to use new nullcheck in set processors #19417

merged 1 commit into from
Jul 14, 2020

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jun 26, 2020

What does this PR do?

A new argument has been added to the set processor to replace null check values, this PR only replaces if conditions with this new argument, no new feature or changes are introduced in this PR.

Why is it important?

Removing if conditions reduces script compilations during ingestion.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Tests

All nosetests passing after change

Related issues

Relates to #19407

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 26, 2020
@P1llus P1llus mentioned this pull request Jun 26, 2020
Closed
42 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 26, 2020 •
edited by jenkins-beats-ci bot
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [P1llus commented: jenkins run tests]

  • Start Time: 2020-07-14T08:52:59.697+0000

  • Duration: 7 min 44 sec

Steps errors

Expand to view the steps failures

  • Name: Make check

    • Description: make check

    • Duration: 0 min 5 sec

    • Start Time: 2020-07-14T08:59:13.037+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-07-14T08:59:21.010Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-14T08:59:21.011Z] Stage "Kubernetes" skipped due to earlier failure(s)
[2020-07-14T08:59:21.086Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.087Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.088Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-07-14T08:59:21.089Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.089Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.090Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.091Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.092Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.093Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-14T08:59:21.571Z] Failed in branch Elastic Agent x-pack
[2020-07-14T08:59:21.571Z] Failed in branch Elastic Agent x-pack Windows
[2020-07-14T08:59:21.572Z] Failed in branch Elastic Agent Mac OS X
[2020-07-14T08:59:21.573Z] Failed in branch Filebeat oss
[2020-07-14T08:59:21.573Z] Failed in branch Filebeat x-pack
[2020-07-14T08:59:21.574Z] Failed in branch Filebeat Mac OS X
[2020-07-14T08:59:21.574Z] Failed in branch Filebeat x-pack Mac OS X
[2020-07-14T08:59:21.575Z] Failed in branch Filebeat Windows
[2020-07-14T08:59:21.575Z] Failed in branch Filebeat x-pack Windows
[2020-07-14T08:59:21.576Z] Failed in branch Auditbeat oss Linux
[2020-07-14T08:59:21.576Z] Failed in branch Auditbeat crosscompile
[2020-07-14T08:59:21.577Z] Failed in branch Auditbeat oss Mac OS X
[2020-07-14T08:59:21.578Z] Failed in branch Auditbeat oss Windows
[2020-07-14T08:59:21.578Z] Failed in branch Auditbeat x-pack
[2020-07-14T08:59:21.579Z] Failed in branch Auditbeat x-pack Mac OS X
[2020-07-14T08:59:21.579Z] Failed in branch Auditbeat x-pack Windows
[2020-07-14T08:59:21.580Z] Failed in branch Libbeat x-pack
[2020-07-14T08:59:21.580Z] Failed in branch Metricbeat OSS Unit tests
[2020-07-14T08:59:21.581Z] Failed in branch Metricbeat OSS Integration tests
[2020-07-14T08:59:21.581Z] Failed in branch Metricbeat Python integration tests
[2020-07-14T08:59:21.582Z] Failed in branch Metricbeat crosscompile
[2020-07-14T08:59:21.583Z] Failed in branch Metricbeat Mac OS X
[2020-07-14T08:59:21.583Z] Failed in branch Metricbeat x-pack Mac OS X
[2020-07-14T08:59:21.584Z] Failed in branch Metricbeat Windows
[2020-07-14T08:59:21.584Z] Failed in branch Metricbeat x-pack Windows
[2020-07-14T08:59:21.585Z] Failed in branch Winlogbeat Windows x-pack
[2020-07-14T08:59:21.585Z] Failed in branch Kubernetes
[2020-07-14T08:59:21.818Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.820Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.821Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-07-14T08:59:21.822Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.823Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:21.824Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-14T08:59:21.876Z] Failed in branch Packetbeat
[2020-07-14T08:59:21.877Z] Failed in branch dockerlogbeat
[2020-07-14T08:59:21.878Z] Failed in branch Journalbeat
[2020-07-14T08:59:22.063Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:22.064Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:22.065Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-14T08:59:22.066Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-14T08:59:22.100Z] Failed in branch Metricbeat x-pack
[2020-07-14T08:59:22.101Z] Failed in branch Winlogbeat
[2020-07-14T08:59:22.267Z] Failed in branch Heartbeat
[2020-07-14T08:59:22.268Z] Failed in branch Libbeat
[2020-07-14T08:59:22.268Z] Failed in branch Functionbeat
[2020-07-14T08:59:22.269Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-14T08:59:22.339Z] Failed in branch Generators
[2020-07-14T08:59:22.458Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19417/src/github.com/elastic/beats
[2020-07-14T08:59:22.760Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-14T08:59:22.773Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19417/src/github.com/elastic/beats/Lint
[2020-07-14T08:59:23.136Z] + cat
[2020-07-14T08:59:23.136Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-14T08:59:23.136Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-14T08:59:29.738Z] runbld>>> runbld started
[2020-07-14T08:59:29.738Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-14T08:59:32.294Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-19417' in order of occurrence in the config (last value wins).
[2020-07-14T08:59:33.236Z] runbld>>> Debug logging enabled.
[2020-07-14T08:59:33.236Z] runbld>>> Storing result
[2020-07-14T08:59:33.236Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-14T08:59:33.236Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200714085932-9B515270
[2020-07-14T08:59:33.236Z] runbld>>> Adding system facts.
[2020-07-14T08:59:34.180Z] runbld>>> Adding vcs info for the latest commit:  facc20915ab461197591d40f7fc3d67456ebb3dc
[2020-07-14T08:59:34.180Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-14T08:59:34.180Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-14T08:59:34.180Z] Processing JUnit reports with runbld...
[2020-07-14T08:59:34.180Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-14T08:59:34.753Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-14T08:59:34.753Z] runbld>>> DURATION: 17ms
[2020-07-14T08:59:34.753Z] runbld>>> STDOUT: 40 bytes
[2020-07-14T08:59:34.753Z] runbld>>> STDERR: 49 bytes
[2020-07-14T08:59:34.753Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-14T08:59:34.753Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-19417/src/github.com/elastic/beats
[2020-07-14T08:59:35.697Z] runbld>>> Storing build metadata: 
[2020-07-14T08:59:35.697Z] runbld>>> Adding test report.
[2020-07-14T08:59:35.697Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-19417/src/github.com/elastic/beats
[2020-07-14T08:59:36.272Z] runbld>>> Found 0 test output files
[2020-07-14T08:59:36.272Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 0 Skipped: 0
[2020-07-14T08:59:36.533Z] runbld>>> Storing result
[2020-07-14T08:59:36.794Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-14T08:59:36.794Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200714085932-9B515270
[2020-07-14T08:59:36.794Z] runbld>>> Email notification disabled by environment variable.
[2020-07-14T08:59:36.794Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-14T08:59:42.583Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-19417
[2020-07-14T08:59:42.801Z] [INFO] getVaultSecret: Getting secrets
[2020-07-14T08:59:42.873Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-14T08:59:43.655Z] + chmod 755 generate-build-data.sh
[2020-07-14T08:59:43.655Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19417/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19417/runs/6 FAILURE 403696
[2020-07-14T08:59:43.655Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19417/runs/6/steps/?limit=10000 -o steps-info.json
[2020-07-14T08:59:43.906Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19417/runs/6/tests/?status=FAILED -o tests-errors.json

@marc-gr
Copy link
Contributor

marc-gr commented Jun 26, 2020

jenkins run tests

@P1llus P1llus force-pushed the santa_module_set_changes branch from 0af8986 to bd957d9 Compare July 13, 2020 19:56
@P1llus P1llus mentioned this pull request Jul 13, 2020
Merged
9 tasks
@P1llus
Copy link
Member Author

P1llus commented Jul 14, 2020

jenkins run tests

@andrewkroh andrewkroh merged commit 77d51c6 into elastic:master Jul 14, 2020
adriansr pushed a commit to adriansr/beats that referenced this pull request Jul 14, 2020
@P1llus @adriansr
updated santa module to use new nullcheck in set processors (elastic#…
bc1287f 
…19417)

(cherry picked from commit 77d51c6)
@adriansr adriansr mentioned this pull request Jul 14, 2020
Merged
6 tasks
adriansr added a commit that referenced this pull request Jul 14, 2020
@adriansr @P1llus
updated santa module to use new nullcheck in set processors (#19417) (#…
76aba38 
…19890)

(cherry picked from commit 77d51c6)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@P1llus @melchiormoulin
updated santa module to use new nullcheck in set processors (elastic#…
d21ba59 
…19417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat review v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@P1llus @elasticmachine @marc-gr @andrewkroh @adriansr