Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19168 to 7.x: Fix unused libbeat.config.module metrics #19294

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jun 18, 2020

Cherry-pick of PR #19168 to 7.x branch. Original message:

What does this PR do?

These metrics existed in the code but were unused and hence always 0.

"libbeat":{"config":{"module":{"running":0,"starts":0,"stops":0}

I updated the module reload code to increment and set the metrics when changes are applied.

Why is it important?

If the metrics are exposed by /stats then they should work, otherwise they are misleading.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Logs

I tested the metrics using Auditbeat module reloading:

  "libbeat": {
    "config": {
      "module": {
        "running": 1,
        "starts": 2,
        "stops": 1
      },
      "reloads": 2,
      "scans": 75
    },

These metrics existed in the code but were unused and hence always 0.

"libbeat":{"config":{"module":{"running":0,"starts":0,"stops":0}

I updated the module reload code to increment and set the metrics when changes are applied.

(cherry picked from commit 5d7e83b)
@andrewkroh andrewkroh added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Jun 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 18, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19294 opened]

  • Start Time: 2020-06-18T19:47:53.336+0000

  • Duration: 79 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 9432
Skipped 1581
Total 11013

@andrewkroh andrewkroh merged commit 1e32e15 into elastic:7.x Jun 18, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
@andrewkroh andrewkroh deleted the backport_19168_7.x branch January 14, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants