Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18882 to 7.x: Add better handling for Kubernetes Update and Delete watcher events #19232

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jun 17, 2020

Cherry-pick of PR #18882 to 7.x branch. Original message:

Improvements for #11834 described on #11834 (comment)

Changes:

  1. Retry on configCheck failures in order to cover stop/start events.
  2. Ignore Update events when status of Pod is Pending.
  3. Emit delete anywayeven if the obj cannot be found in thestore` at
    o, exists, err := w.store.GetByKey(key)
    , so as to ensure that states are cleaned anyway.

@ChrsMark ChrsMark added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jun 17, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2020
@ChrsMark ChrsMark self-assigned this Jun 17, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19232 opened]

  • Start Time: 2020-06-17T07:09:44.197+0000

  • Duration: 79 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 6778
Skipped 1069
Total 7847

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-17T07:35:47.462+0000

    • log

@ChrsMark ChrsMark requested review from a team June 17, 2020 09:29
@ChrsMark ChrsMark merged commit 999fb5c into elastic:7.x Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants