Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] S3 input: try to detect GZIPped objects (#18764) #18937

Merged
merged 1 commit into from
Jun 3, 2020
Merged

[7.x] S3 input: try to detect GZIPped objects (#18764) #18937

merged 1 commit into from
Jun 3, 2020

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.x:

* Try to detect GZIP based on content encoding header

* Check GZIP contents

* Log error before returning it

* Fixing typo

* Add comment

* Adding comment

* Adding CHANGELOG entry

* Add test case for empty contents
@ycombinator ycombinator added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team Team:Platforms Label for the Integrations - Platforms team and removed Team:Services (Deprecated) Label for the former Integrations-Services team labels Jun 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elastic elastic deleted a comment from elasticmachine Jun 3, 2020
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry I missed the original PR...

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18937 opened]

  • Start Time: 2020-06-03T13:58:36.219+0000

  • Duration: 59 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 1716
Skipped 255
Total 1971

@ycombinator ycombinator merged commit 2974ffc into elastic:7.x Jun 3, 2020
@ycombinator ycombinator deleted the backport/7.x/pr-18764 branch June 3, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants