Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.8][docs] Backport: Use beatname_pkg variable to resolve package name (#18423) #18442

Merged
merged 1 commit into from
May 12, 2020

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented May 12, 2020

Backports #18423 to 7.8 branch.

@dedemorton dedemorton added docs backport Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0 labels May 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
@dedemorton dedemorton merged commit 1bb6d29 into elastic:7.8 May 12, 2020
@dedemorton dedemorton deleted the backport_18419_7.8 branch May 12, 2020 22:09
@eddieturizo
Copy link

@dedemorton Curious to know why we did not back port the doc change to when the underlying code began using heartbeat-elastic ? The 7.6 docs still reflect heartbeat instead of heartbeat-elastic. Am I missing something?

@dedemorton
Copy link
Contributor Author

@eddieturizo Typically we only backport changes to versions that we are actively maintaining. If you look at the older version of the docs, you'll see "IMPORTANT: No additional bug fixes or documentation updates will be released for this version."

Having said that...maybe this change is important enough to backport anyhow.

@eddieturizo
Copy link

@dedemorton Thank you for calling my attention to that. I strongly advocate we back port the changes to match the source code. The way the docs exist today, we are (incorrectly) asking users to invoke:

systemctl start heartbeat

in the 7.6 docs [0] when it should really be:

systemctl start heartbeat-elastic

Please re-consider.

[0] https://www.elastic.co/guide/en/beats/heartbeat/7.6/running-with-systemd.html

@dedemorton
Copy link
Contributor Author

Done. We can always do this on a case-by-case basis. Thanks for your input!

@eddieturizo
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport docs Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants