Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] fix a typo in the ACK message. #18396

Merged
merged 1 commit into from
May 11, 2020
Merged

[Elastic Agent] fix a typo in the ACK message. #18396

merged 1 commit into from
May 11, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented May 8, 2020

Small typo in the ACK message

Fixes: #18145

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
[Elastic Agent] fix a typo in the ACK message.
54c134e 
Small typo in the ACK message

Fixes: #18145
@ph ph added review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Ingest Management Ingest Management:beta1 Group issues for ingest management beta1 labels May 8, 2020
@ph ph requested a review from michalpristas May 8, 2020 19:55
@ph ph self-assigned this May 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

kaiyan-sheng
kaiyan-sheng approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@dedemorton
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 9, 2020
michalpristas
michalpristas approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ph ph merged commit 5b1927e into elastic:master May 11, 2020
@ph ph mentioned this pull request May 12, 2020
Merged
6 tasks
@ph ph added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 12, 2020
ph added a commit that referenced this pull request May 13, 2020
@ph
[Elastic Agent] fix a typo in the ACK message. (#18396) (#18451)
50281fe 
Small typo in the ACK message

Fixes: #18145
(cherry picked from commit 5b1927e)
ph added a commit that referenced this pull request May 13, 2020
@ph
[Elastic Agent] fix a typo in the ACK message. (#18396) (#18414)
8eabfee 
Small typo in the ACK message

Fixes: #18145
(cherry picked from commit 5b1927e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@michalpristas michalpristas michalpristas approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@ph ph

Labels
Ingest Management:beta1 Group issues for ingest management beta1 review v7.8.0 [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Elastic Agent] Typo in action ack message
7 participants
@ph @elasticmachine @dedemorton @ruflin @michalpristas @kaiyan-sheng @andresrc