Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused flag in Checkpoint module configuration #18389

Merged
merged 1 commit into from
May 15, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented May 8, 2020

What does this PR do?

This removes references to var.log_level in checkpoint module's configuration. This variable is not used, just a left-over from using the cisco module as a base.

Why is it important?

Avoid confusing users with a configuration option that does nothing and references docs from a different vendor.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

This removes references to `var.log_level` in checkpoint module's
configuration. This variable is not used, just a left-over from using
the cisco module as a base.
@adriansr adriansr added review needs_backport PR is waiting to be backported to other branches. Team:SIEM labels May 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2020
@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 8, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 1184
Skipped 128
Total 1312

@adriansr
Copy link
Contributor Author

jenkins, test this

@adriansr
Copy link
Contributor Author

jenkins, test this

@adriansr adriansr merged commit e742954 into elastic:master May 15, 2020
adriansr added a commit to adriansr/beats that referenced this pull request May 15, 2020
This removes references to `var.log_level` in checkpoint module's
configuration. This variable is not used, just a left-over from using
the cisco module as a base.

(cherry picked from commit e742954)
@adriansr adriansr added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 15, 2020
adriansr added a commit to adriansr/beats that referenced this pull request May 15, 2020
This removes references to `var.log_level` in checkpoint module's
configuration. This variable is not used, just a left-over from using
the cisco module as a base.

(cherry picked from commit e742954)
adriansr added a commit that referenced this pull request May 15, 2020
This removes references to `var.log_level` in checkpoint module's
configuration. This variable is not used, just a left-over from using
the cisco module as a base.

(cherry picked from commit e742954)
adriansr added a commit that referenced this pull request May 15, 2020
This removes references to `var.log_level` in checkpoint module's
configuration. This variable is not used, just a left-over from using
the cisco module as a base.

(cherry picked from commit e742954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants