-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused flag in Checkpoint module configuration #18389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes references to `var.log_level` in checkpoint module's configuration. This variable is not used, just a left-over from using the cisco module as a base.
adriansr
added
review
needs_backport
PR is waiting to be backported to other branches.
Team:SIEM
labels
May 8, 2020
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
May 8, 2020
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
|
jenkins, test this |
leehinman
approved these changes
May 14, 2020
jenkins, test this |
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
May 15, 2020
This removes references to `var.log_level` in checkpoint module's configuration. This variable is not used, just a left-over from using the cisco module as a base. (cherry picked from commit e742954)
1 task
adriansr
added
v7.9.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
May 15, 2020
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
May 15, 2020
This removes references to `var.log_level` in checkpoint module's configuration. This variable is not used, just a left-over from using the cisco module as a base. (cherry picked from commit e742954)
1 task
adriansr
added a commit
that referenced
this pull request
May 15, 2020
adriansr
added a commit
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This removes references to
var.log_level
in checkpoint module's configuration. This variable is not used, just a left-over from using the cisco module as a base.Why is it important?
Avoid confusing users with a configuration option that does nothing and references docs from a different vendor.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.