Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic-Agent] Follow home path for all config files #18161

Merged
merged 3 commits into from
May 4, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 4, 2020

What does this PR do?

Currently even if specified fleet.yml and action_store.yml files are generated next to binary (which is default home). This PR makes it so these files are generated in actual home (path.home) spcified by user.

Why is it important?

To have a the same behavior across config files

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #17967

@michalpristas michalpristas self-assigned this May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good move to info*

@michalpristas michalpristas merged commit 1c6b278 into elastic:master May 4, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 4, 2020
* fleet.yml at home

* action_store

* changelog
michalpristas added a commit that referenced this pull request May 4, 2020
* fleet.yml at home

* action_store

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ingest Management:alpha1 Group issues for ingest management alpha1 review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Elastic-Agent] All generated config files should follow path.home
4 participants