Fix fields validation in non utf-8 environments #18130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integrations (Team:Integrations) |
|
Maybe environments have been always running without utf-8, I can reproduce this failure since #17650, where no change in environments was done. Some character in the new fields added there? 🤔 |
6 tasks
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
kvch
approved these changes
Apr 30, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 30, 2020
There was a non-ascii character in fields documentation that was making fields validation in some tests to fail. Fix fields validation to don't fail on this case, and replace the non-ascii character. (cherry picked from commit 93b5998)
jsoriano
added a commit
that referenced
this pull request
Apr 30, 2020
There was a non-ascii character in fields documentation that was making fields validation in some tests to fail. Fix fields validation to don't fail on this case, and replace the non-ascii character. (cherry picked from commit 93b5998)
|
Thank you for fixing it!!! I finally realized encoding="utf_8" was the problem in #18112 and then realized you already fixed it 👍 👍 👍 👍 Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a non-ascii character in fields documentation that was making
fields validation in some tests to fail.
Fix fields validation to don't fail on this case, and replace the non-ascii character.
This should fix tests failing like this one: